Parse Error: syntax error: unexpected '{' [closed]

Question

I have this code that processes a user then redirects them to the user homepage.

<?php
    $username = $_POST['username'];
    $password = $_POST['pwd'];

    $file = file_get_contents("userdb.html");
    if(!strpos($file, $username)) {
        echo "Your username was not found in our database. Please go back and try again.";
    } else {
        echo "Redirecting...";
        if (md5($password) == !strpos($file, (md5($password))) {
             echo "Redirecting..."
             header ('Location: ./userhome.php')
        } else {
             print "Whoops! Your password seems to be incorrect. Go back and try again."
        }
    }
?>

And I get the error:

Parse error: syntax error, unexpected '{' in userprocess.php on line 11

Could someone tell me the problem please? I think it may be the if inside of if statement, but what can I do for an alternative? Thanks.

Try to use good IDE and you'll see syntax errors marked. NetBeans or PhpStorm. — user680786
– user680786, Commented Aug 14, 2011 at 21:26
Are you going to come back soon and ask, why redirection didn't work? — Linus Kleen
– Linus Kleen, Commented Aug 14, 2011 at 21:26
Are you really saving usernames and passwords in an html file? Even if you hash and salt, you should still not hand them out. — Marcel
– Marcel, Commented Aug 17, 2014 at 2:22

Spudley · Accepted Answer · 2011-08-14 21:18:15Z

4

Firstly, this line is missing a closing bracket:

if (md5($password) == !strpos($file, (md5($password))) {

Count the number of ( and ) -- they need to match.

When you fix this, you'll still get errors, because PHP statements need to end with semi-colons.

All of the following lines are missing their semi-colon:

echo "Redirecting..."
header ('Location: ./userhome.php')
print "Whoops! Your password seems to be incorrect. Go back and try again."

You need to fix them all before you'll be able to run the program without syntax errors.

Hope that helps.

answered Aug 14, 2011 at 21:18

Spudley

169k39 gold badges240 silver badges309 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

snarkyt123 Over a year ago

Right after I posted this I realized the semicolons (a seriously stupid problem for me) but thank you for the fix of the if statement. It was a well thought out an clear answer. Thank you.

Linus Kleen Over a year ago

Also, an echo followed by header and print is just too obvious an error to ignore...

Spudley Over a year ago

@Linus - indeed, but I was already straying outside the bounds of the original question by pointing out the semicolons. :)

Marcelo · Accepted Answer · 2011-08-14 21:15:02Z

1

You are missing a right parenthesis in the line:

if (md5($password) == !strpos($file, (md5($password))) {

answered Aug 14, 2011 at 21:15

Marcelo

2,3123 gold badges23 silver badges32 bronze badges

Comments

Ernestas Stankevičius · Accepted Answer · 2011-08-14 21:17:16Z

1

<?php
    $username = $_POST['username'];
    $password = $_POST['pwd'];

    $file = file_get_contents("userdb.html");
    if(!strpos($file, $username)) {
        echo "Your username was not found in our database. Please go back and try again.";
    } else {
        echo "Redirecting...";
        if (md5($password) == !strpos($file, md5($password))) {
             echo "Redirecting...";
             header ('Location: ./userhome.php');
        } else {
             print "Whoops! Your password seems to be incorrect. Go back and try again.";
        }
    }
?>

answered Aug 14, 2011 at 21:17

Ernestas Stankevičius

2,5132 gold badges25 silver badges31 bronze badges

Comments

Shef · Accepted Answer · 2011-08-14 21:14:33Z

1

Change

if (md5($password) == !strpos($file, (md5($password)))

to

if (md5($password) == !strpos($file, md5($password)))

answered Aug 14, 2011 at 21:14

Shef

45.6k15 gold badges82 silver badges91 bronze badges

Collectives™ on Stack Overflow

Parse Error: syntax error: unexpected '{' [closed]

4 Answers 4

3 Comments

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Linked

Related