How to use a SubString method with string array in java [duplicate]

Question

class DownloadFileAsync extends AsyncTask<String, String, String> {

        @Override
        protected String doInBackground(String... params) {
            // TODO Auto-generated method stub

            int count;
            String destination = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS) + "/" ;


            String[] fileName = params;
            String a = fileName.toString();
            String b = a.substring(20,25);
            destination+=b;


            try {

                URL url = new URL(params[0]);
                URLConnection conexion = url.openConnection();
                conexion.connect();

                int lengthofFile = conexion.getContentLength();
                Log.d("ANDRO_ASYNC", "Length of file: " + lengthofFile);

                InputStream input = new BufferedInputStream(url.openStream());
                OutputStream output = new FileOutputStream(destination);

                byte data[] = new byte[1024];

                long total = 0;

                while ((count = input.read(data)) != -1) {
                    total += count;
                    publishProgress("" + (int) ((total * 100) / lengthofFile));
                    output.write(data, 0, count);
                }

                output.flush();
                output.close();
                input.close();
            } catch (Exception e) {
                // TODO: handle exception
            }
            return null;
        }

my param variable will contain the url link which is "http://ledeveloper.in/ep123BCA.pdf" and i want to cut that url..the desire string which i want "ep123BCA.pdf".

But when i run this code the substring Method will always give me a different sub string how to solve that problem.

please help and thanx in advance.

use split method String[] parts= url.split("/"); it will split the url into 3 or 4 parts, last one is the file name , this is a one way — Mohammed Elrashied
– Mohammed Elrashied, Commented Jan 25, 2017 at 11:29
not working for me that give me a same garbage name of the downloaded file. :( — Saurabh Saini
– Saurabh Saini, Commented Jan 25, 2017 at 12:30

diiN__________ · Accepted Answer · 2017-01-25 11:33:26Z

2

Use lastIndexOf to get the file name from the URL:

String b = a.substring(a.lastIndexOf('/') + 1);

edited Jan 25, 2017 at 11:33

answered Jan 25, 2017 at 11:27

diiN__________

7,7197 gold badges49 silver badges74 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rahul Giradkar · Accepted Answer · 2017-01-25 11:29:13Z

0

You can use this.

fileName=a.substring(a.lastIndexOf("/")+1);

answered Jan 25, 2017 at 11:29

Rahul Giradkar

1,8181 gold badge18 silver badges29 bronze badges

Comments

jonaslagoni · Accepted Answer · 2017-01-25 11:31:21Z

0

Another solution is (if the first part of the url never change)

a.substring(22)

This should split the string this way:

the part cut out = http://ledeveloper.in/
a = ep123BCA.pdf

answered Jan 25, 2017 at 11:31

jonaslagoni

8509 silver badges25 bronze badges

3 Comments

Todor Kostov Over a year ago

It is a solution, but it's not flexible enough.

jonaslagoni Over a year ago

That is most certainly correct :)

Saurabh Saini Over a year ago

giving a garbage name of the file.

Karthik CP · Accepted Answer · 2017-01-25 11:32:53Z

0

String url = "http://ledeveloper.in/ep123BCA.pdf";
         String file = url.substring(url.lastIndexOf('/')+1);

answered Jan 25, 2017 at 11:32

Karthik CP

1,20013 silver badges24 bronze badges

Comments

Ronak Chaniyara · Accepted Answer · 2017-01-25 11:46:39Z

0

filename = a.substring(a.lastIndexOf("/")+1);

This line replace with your code.

edited Jan 25, 2017 at 11:46

Ronak Chaniyara

5,4363 gold badges28 silver badges56 bronze badges

answered Jan 25, 2017 at 11:35

surilshah08

11 bronze badge

Collectives™ on Stack Overflow

How to use a SubString method with string array in java [duplicate]

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

3 Comments

Comments

Comments

Linked

Related