Closing SqlConnection and SqlCommand c#

Question

In my DAL I write queries like this:

using(SQLConnection conn = "connection string here")
{
    SQLCommand cmd = new ("sql query", conn);
    // execute it blah blah
}

Now it just occurred to me that I am not explicitly closing the SQLCommand object. Now I know the 'using' block will take care of the SQLConnection object, but will this also take care of the SQLCommand object? If not than I have a serious problem. I would have to put in the 'using' on the SQLCommand on thousands and thousands of lines of code or do a cmd.Close() on hundreds of methods. Please tell me that if putting in the using or closing the command will provide a better memory management of the web app?

I think this also should be interesting to you: valueinjecter.codeplex.com/… — Omu
– Omu, Commented Jul 30, 2010 at 11:37

Fredrik Mörk · Accepted Answer · 2010-07-30 10:01:48Z

13

The SqlConnection has no knowledge about the SqlCommand, so you should close it by itself:

using (SqlConnection conn = new SqlConnection("connection string here"))
using (SqlCommand cmd = new SqlCommand("sql query", conn))
{
    // execute it blah blah
}

answered Jul 30, 2010 at 10:01

Fredrik Mörk

159k31 gold badges296 silver badges349 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Oded · Accepted Answer · 2010-07-30 11:31:12Z

10

No, the using statement will not take care of the command.

You should wrap the commands with using statements as well, since this will properly call Dispose on them:

using(SQLConnection conn = 'connection string here')
{
    using(SQLCommand cmd = new ('sql query', conn))
    {
        //execute it blah blah
    }
}

edited Jul 30, 2010 at 11:31

answered Jul 30, 2010 at 10:02

Oded

501k102 gold badges900 silver badges1k bronze badges

Comments

Adam Houldsworth · Accepted Answer · 2010-07-30 10:01:53Z

5

It won't handle the SqlCommand, but the SqlCommand will eventually be handled by the garbage collector. I tend to do the following:

using (SqlConn conn ... )
using (SqlComm comm ... )
{
    conn.Open();
}

Stacking the using statements here will handle both.

answered Jul 30, 2010 at 10:01

Adam Houldsworth

64.8k11 gold badges161 silver badges190 bronze badges

Collectives™ on Stack Overflow

Closing SqlConnection and SqlCommand c#

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related