Using Javascript variables within a string [duplicate]

Question

I am using JQuery to output a link to my webpage. Part of the link is dynamic, and I am having trouble using variables and text together. The variable just gets treated as text. What am I doing wrong?

My Jquery:

var new_collection_id= 1;
var new_collection_title= 'This is a title';

.html('<a href="collection.php?id=1&collection=new_collection_id">     
new_collection_title </a>')

How the script should know that those are variables? String Concatenation. — Ram
– Ram, Commented Jan 31, 2014 at 20:27

user3141031 · Accepted Answer · 2014-01-31 20:27:59Z

3

You need to use concatenation.

.html('<a href="collection.php?id=1&collection=' + new_collection_id + '">' + new_collection_title + ' </a>')

answered Jan 31, 2014 at 20:27

user3141031

Sign up to request clarification or add additional context in comments.

Comments

Satpal · Accepted Answer · 2014-01-31 20:32:53Z

3

You need to use string concatenation.

.html('<a href="collection.php?id=1&collection=' + new_collection_id 
     + '">' +  new_collection_title + '</a>')

Ideally I would suggest you to use

.html( $('<a></a>')
      .text(new_collection_title)
      .attr('href', 'collection.php?id=1&collection=' + new_collection_id)
    )

DEMO

edited Jan 31, 2014 at 20:32

answered Jan 31, 2014 at 20:27

Satpal

134k13 gold badges168 silver badges171 bronze badges

2 Comments

Barmar Over a year ago

@plalx While that's needed in general, you can do without it when you know the ID is always a number.

plalx Over a year ago

@Barmar I know, however there's no way to tell here... well now it seems there is since the OP modified the question ;)

Collectives™ on Stack Overflow

Using Javascript variables within a string [duplicate]

2 Answers 2

Comments

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Linked

Related