Refactor with quickstart PMD analysis

anitsh · anitsh · commit 75fe1606fbc2 · 2022-10-04T13:08:00.000+04:00
./run.sh pmd -d /home/anit/work/codechallenge-java-pom/src/main/java/hackerrank/java/StringToken.java -f text -R rulesets/java/quickstart.xml --cache /tmp/codechallenge-pmd-analysis | less
diff --git a/src/main/java/hackerrank/java/StringToken.java b/src/main/java/hackerrank/java/StringToken.java
@@ -13,8 +13,7 @@ public String[] tokenFilter() {
                 || sentence.trim().isEmpty()) {
             return new String[]{};
         }
-        String[] splitStr = sentence.trim().split("[,\\s\\'\\?\\_\\@\\!\\.]+");
 
-        return splitStr;
+        return sentence.trim().split("[,\\s\\'\\?\\_\\@\\!\\.]+");
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,7 @@ public String[] tokenFilter() {`
`13`	`13`	`\|\| sentence.trim().isEmpty()) {`
`14`	`14`	`return new String[]{};`
`15`	`15`	`}`
`16`		`- String[] splitStr = sentence.trim().split("[,\\s\\'\\?\\_\\@\\!\\.]+");`
`17`	`16`
`18`		`- return splitStr;`
	`17`	`+ return sentence.trim().split("[,\\s\\'\\?\\_\\@\\!\\.]+");`
`19`	`18`	`}`
`20`	`19`	`}`