Quickstart PMD analysis

 ./run.sh pmd -d /home/anit/work/codechallenge-java-pom/src/main/java/hackerrank/api -f text -R rulesets/java/quickstart.xml --cache /tmp/codechallenge-pmd-analysis | more
PMD violation messages can be suppressed with @SuppressWarnings("PMD.VIOLATION_CLASS")

Author: anitsh

src/main/java/hackerrank/api/BarcodeReader.java

@@ -12,11 +12,10 @@
 
 public class BarcodeReader   {
 
-    private static final String TAG = HttpHandler.class.getSimpleName();
+    private final static String TAG = HttpHandler.class.getSimpleName();
     private final static Logger logger =
             Logger.getLogger(Logger.GLOBAL_LOGGER_NAME);
-    private final String barcodeURI = "https://jsonmock.hackerrank.com/api/inventory?barcode=";
-    private Inventory inventory;
+    private final static String barcodeURI = "https://jsonmock.hackerrank.com/api/inventory?barcode=";
 
     public Inventory read(int barcode)
             throws BarcodeNotFoundException {
@@ -30,15 +29,22 @@ public Inventory read(int barcode)
             inventories =  getInventories(inventoryJSONString);
 
         } catch (MalformedURLException e) {
-            logger.log(Level.WARNING, TAG + " MalformedURLException: " + e.getMessage());
+            if (logger.isLoggable(Level.SEVERE)) {
+                logger.log(Level.SEVERE, TAG + " MalformedURLException: " + e.getMessage());
+            }
         } catch (IOException e) {
-            logger.log(Level.WARNING, TAG + " IOException: " + e.getMessage());
+            if (logger.isLoggable(Level.SEVERE)) {
+                logger.severe(TAG + " IOException: " + e.getMessage());
+            }
         } catch (Exception e) {
-            logger.log(Level.WARNING, TAG + " Exception: " + e.getMessage());
+            if (logger.isLoggable(Level.SEVERE)) {
+                logger.severe(TAG + " Exception: " + e.getMessage());
+            }
         }
 
-        if ( inventories.length == 0 )
+        if ( inventories.length == 0 ) {
             throw new BarcodeNotFoundException("Barcode Not Found!");
+        }
 
         return inventories[0];
     }

src/main/java/hackerrank/api/HttpRequests.java

@@ -5,8 +5,7 @@
 import java.net.HttpURLConnection;
 import java.net.URL;
 
-class HttpRequests {
-
+public abstract class HttpRequests {
     public static InputStream get(String url)
             throws IOException {
         InputStream inputStream = null;

src/main/java/hackerrank/api/InputStreamConverter.java

@@ -8,7 +8,7 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 
-class InputStreamConverter {
+public abstract class InputStreamConverter {
 
     public static String toString(InputStream is) {
 

src/main/java/hackerrank/api/Inventory.java

@@ -1,15 +1,6 @@
 package hackerrank.api;
 
-import com.sun.net.httpserver.HttpHandler;
-
-import java.util.logging.Logger;
-
 public class Inventory {
-    private final static Logger logger =
-            Logger.getLogger(Logger.GLOBAL_LOGGER_NAME);
-    private static final String TAG = HttpHandler.class.getSimpleName();
-
-    private final String URL = "https://jsonmock.hackerrank.com/api/inventory?barcode=";
 
     String item;
     int price;