-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Open
Labels
Area-CompilersConcept-Design DebtEngineering Debt, Design Debt, or poor product code qualityEngineering Debt, Design Debt, or poor product code quality
Milestone
Description
Came up in code review of #77192
Things to consider:
- Should CachingSemanticModelProvider be merged with it's base class as it's the only class in the product derived from SemanticModelProvider?
- Should CachingSemanticModelProvider be made static as it only uses static data?
- Should the Clear* methods be reconsidered? As part of that PR, it was stated that the CompilationEnd notification is intentionally no longer being sent. This is the notification that triggers the Clear(Compilation) method, so we should either reconsider sending the CompilationEnd notification or remove the Clear(Compilation) method from CachingSemanticModelProvider as it's misleading in it's current form.
Metadata
Metadata
Assignees
Labels
Area-CompilersConcept-Design DebtEngineering Debt, Design Debt, or poor product code qualityEngineering Debt, Design Debt, or poor product code quality