-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Comparing changes
Open a pull request
base repository: dotnet/maui
base: 10.0.10
head repository: dotnet/maui
compare: release/10.0.1xx-sr1
- 15 commits
- 19 files changed
- 8 contributors
Commits on Nov 13, 2025
-
Configuration menu - View commit details
-
Copy full SHA for f9950cf - Browse repository at this point
Copy the full SHA f9950cfView commit details
Commits on Nov 14, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 06fb352 - Browse repository at this point
Copy the full SHA 06fb352View commit details -
Removed Value property coercion in RadioButton (#32604)
Eliminated the coercion logic that set RadioButton.Value to the instance when null, allowing Value to be explicitly set to null. Updated related unit test to reflect the new behavior. Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b131a12 - Browse repository at this point
Copy the full SHA b131a12View commit details
Commits on Nov 15, 2025
-
Refactor selection limit handling in MediaPicker (#32628)
Replaces direct access to options.SelectionLimit with a local variable that defaults to 1 if options is null. Updates all relevant checks and method calls to use the new variable, improving null safety and code clarity. Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a350361 - Browse repository at this point
Copy the full SHA a350361View commit details
Commits on Nov 17, 2025
-
[release/10.0.1xx-sr1] predictive back gesture support for Android 13+ (
#32635) * Add predictive back gesture support for Android 13+ Introduces a unified HandleBackNavigation method to centralize back navigation handling and integrates Android 13+ predictive back gesture callbacks with MAUI lifecycle events. Predictive back is registered and unregistered appropriately, ensuring custom back handling works with system back gesture animation. * Fix predictive back callback registration and resource management - Fix potential double registration by checking if callback is null before creating/registering - Add Dispose() call in OnDestroy() to prevent memory leaks - Change field type to concrete PredictiveBackCallback for better performance (CA1859) - Add comment explaining PRIORITY_DEFAULT value These changes address code review feedback while maintaining the PR's core functionality. * Simplify code to reduce nesting --------- Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Configuration menu - View commit details
-
Copy full SHA for 0d9ac81 - Browse repository at this point
Copy the full SHA 0d9ac81View commit details
Commits on Nov 19, 2025
-
Fix crash when TimePicker.Time is set to null (backport from PR #32660)…
… (#32715) * Initial plan * Fix crash when TimePicker.Time is set to null (backport from PR #32660) Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b5d476f - Browse repository at this point
Copy the full SHA b5d476fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1b6d64 - Browse repository at this point
Copy the full SHA d1b6d64View commit details -
Fix TabbedPage crash on iPadOS 26+ with narrow viewports
Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d948728 - Browse repository at this point
Copy the full SHA d948728View commit details -
Fix TabbedPage crash on iPadOS 26+ with narrow viewports (#32739)
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Description of Change On iPadOS 26.1+, `TabbedPage` crashes with `NullReferenceException` in windowed apps < 667pt width. iOS 26.1 introduced early `ViewDidLayoutSubviews()` calls during `UITabBarController` base constructor execution for narrow viewports, before `_viewHandlerWrapper` initialization completes. **Fix:** Add null-conditional operator to `Element` property getter: ```diff - public VisualElement Element => _viewHandlerWrapper.Element ?? _element?.GetTargetOrDefault(); + public VisualElement Element => _viewHandlerWrapper?.Element ?? _element?.GetTargetOrDefault(); ``` The existing `if (Element is IView view)` guard in `ViewDidLayoutSubviews()` handles null safely. ### Issues Fixed Fixes #32661 <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Backport #32662 </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
Configuration menu - View commit details
-
Copy full SHA for 3081e5c - Browse repository at this point
Copy the full SHA 3081e5cView commit details -
Fix content page title clipping on Android API < 30 with window inset…
…s compatibility (#32738) * Initial plan * Add NavigationRootManager fix and test cases for Issue32526 Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 00c60b3 - Browse repository at this point
Copy the full SHA 00c60b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dcbc85 - Browse repository at this point
Copy the full SHA 9dcbc85View commit details
Commits on Nov 20, 2025
-
Backport pipeline configuration fixes from PRs #32610, #32694, #32779 (…
…#32781) * Initial plan * Backport PRs #32610, #32694, #32779 - pipeline configuration fixes Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3f31022 - Browse repository at this point
Copy the full SHA 3f31022View commit details
Commits on Nov 21, 2025
-
[release/10.0.1xx-sr1] Fix iOS 26 TitleView covering content in Shell…
… and NavigationPage (#32798) * Initial plan * Implement improved fix for iOS 26 TitleView covering content issue - Added CreateTitleViewContainer helper method to reduce code duplication - Improved iOS 26+ detection with proper fallback when navigation bar frame unavailable - Set frame origin to (0,0) instead of preserving potentially uninitialized X/Y values - Added comprehensive XML documentation explaining iOS 26 workaround - Added test case and UI test for Issue32287 This implementation addresses the critical issues identified in PR #32337 review: - Eliminates silent failure by providing fallback to standard constructor - Clarifies frame positioning logic with explicit (0,0) origin - Reduces code duplication through helper method - Adds proper documentation for maintainability Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Apply iOS 26 TitleView fix to NavigationPage Extended the iOS 26+ TitleView fix to NavigationPage in addition to Shell: 1. Added CreateTitleViewContainer helper method to centralize container creation 2. Added Container constructor overload accepting navigation bar frame for iOS 26+ 3. Refactored Container initialization to use InitializeContainer method 4. Updated ToolbarHeight to use actual navigation bar height when available 5. Eliminated hardcoded 44pt height assumption for iOS 26+ This ensures both Shell and NavigationPage TitleView implementations handle iOS 26 layout changes consistently, preventing TitleView from covering page content. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Enhance Issue32287 test with rotation and dynamic content size changes Extended the Issue32287 test based on review feedback: 1. Added rotation test to verify TitleView behavior in landscape mode 2. Added dynamic font size change tests to verify container tracks nav bar changes 3. Added buttons to increase/decrease TitleView font size 4. Added x:Name to TitleLabel for programmatic access 5. Created placeholder snapshot image for test validation 6. Wrapped rotation tests with TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST Tests now comprehensively verify that TitleView container correctly tracks navigation bar frame changes without covering content in all scenarios. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * - update tests * Add NavigationPage equivalent tests for Issue32287 Created comprehensive NavigationPage tests mirroring the Shell tests: 1. Issue32287NavigationPage.xaml - NavigationPage with custom TitleView 2. Issue32287NavigationPage.xaml.cs - Code-behind with font size controls 3. Issue32287NavigationPage.cs - UI tests matching Shell test scenarios: - Basic test verifying TitleView doesn't cover content - Dynamic content size change test - Landscape rotation test (iOS/Android only) 4. Created placeholder snapshot image for visual validation Tests verify that the NavigationPage Container fix handles iOS 26+ layout changes consistently with Shell, preventing TitleView from covering content. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * Fix NavigationPage XAML structure and add platform-specific comments Fixed XAML parsing error and addressed PR review feedback: 1. Changed Issue32287NavigationPage from NavigationPage to ContentPage - NavigationPage cannot have content directly set in XAML - NavigationPage.TitleView is an attached property set on ContentPage - Updated base class from NavigationPage to ContentPage 2. Added explanatory comments for platform-specific conditionals - Documented that rotation tests only work on iOS/Android - Explained SetOrientationLandscape/Portrait not supported on Windows/Catalyst - Applied to both Issue32287 and Issue32287NavigationPage test files Fixes XAML error: "Cannot set the content of NavigationPage as it doesn't have a ContentPropertyAttribute" Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> * - fix navigation page * Delete src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/CustomTitleViewDoesNotCoverContent.png * Delete src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue32287NavigationPageCustomTitleViewDoesNotCoverContent.png * - fix tests and add suggested fix * Remove all test files from PR Deleted all Issue32287 test files as requested: - Issue32287.xaml and Issue32287.xaml.cs (Shell tests) - Issue32287NavigationPage.xaml and Issue32287NavigationPage.xaml.cs (NavigationPage tests) - Issue32287.cs and Issue32287NavigationPage.cs (UI test implementations) The PR now contains only the iOS 26 TitleView fix implementation without test coverage. Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 3218849 - Browse repository at this point
Copy the full SHA 3218849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b90830 - Browse repository at this point
Copy the full SHA 7b90830View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa9ced - Browse repository at this point
Copy the full SHA 5aa9cedView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 10.0.10...release/10.0.1xx-sr1