-
Notifications
You must be signed in to change notification settings - Fork 548
Open
Labels
app-sizeenhancementThe issue or pull request is an enhancementThe issue or pull request is an enhancementgeneratorIssues affecting the generatorIssues affecting the generatorgood first issueThis is a good first issue for someone to start working with our codeThis is a good first issue for someone to start working with our codeperformanceIf an issue or pull request is related to performanceIf an issue or pull request is related to performance
Milestone
Description
There are numerous places where we can improve the generated code.
Example:
[MonoPInvokeCallback (typeof (DQLPreviewReplyDataCreationHandler))]
static unsafe IntPtr Invoke (IntPtr block, IntPtr reply, ref IntPtr error) {
var descriptor = (BlockLiteral *) block;
var del = (global::QuickLook.QLPreviewReplyDataCreationHandler) (descriptor->Target);
var __xamarin_pref1 = Runtime.GetINativeObject<NSError> (error, false);
Foundation.NSData retval = del ( Runtime.GetNSObject<QLPreviewReply> (reply), ref __xamarin_pref1);
error = __xamarin_pref1 is null ? IntPtr.Zero : __xamarin_pref1.Handle;
return retval.GetHandle ();
}Runtime.GetINativeObject<NSError>should beGetNSObjecterror = __xamarin_pref1 is null ? IntPtr.Zero : __xamarin_pref1.Handle;should beerror =__xamarin_pref1.GetHandle ()`;
We should look at the generated code to find more opportunities.
Metadata
Metadata
Assignees
Labels
app-sizeenhancementThe issue or pull request is an enhancementThe issue or pull request is an enhancementgeneratorIssues affecting the generatorIssues affecting the generatorgood first issueThis is a good first issue for someone to start working with our codeThis is a good first issue for someone to start working with our codeperformanceIf an issue or pull request is related to performanceIf an issue or pull request is related to performance