Skip to content

Commit c7b5e07

Browse files
[release/10.0] Source code updates from dotnet/dotnet (#2730)
* Update dependencies from https://github.com/dotnet/dotnet build 290774 Updated Dependencies: Microsoft.DotNet.Arcade.Sdk (Version 9.0.0-beta.25407.2 -> 10.0.0-beta.25563.104) * Update global.json * Delete eng/DotNetBuild.props * Delete Directory.Build.rsp * Update .vsts-ci.yml * Refactor CI configuration in .vsts-ci-official.yml Removed unused variables and updated build job configurations. * Clean up .vsts-ci.yml by removing variables Removed unused variables and build arguments from CI configuration. * Simplify CI script by combining commands --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
1 parent c9a0655 commit c7b5e07

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+2095
-894
lines changed

.vsts-ci-official.yml

Lines changed: 16 additions & 166 deletions
Original file line numberDiff line numberDiff line change
@@ -1,188 +1,38 @@
11
variables:
2-
- name: _TeamName
3-
value: DotNetCore
4-
- name: _DotNetArtifactsCategory
5-
value: .NETCore
6-
- name: Codeql.Enabled
7-
value: true
8-
# CodeQL3000 needs this plumbed along as a variable to enable TSA.
9-
- name: Codeql.TSAEnabled
10-
value: true
11-
- name: Codeql.TSAOptionsPath
12-
value: '$(Build.SourcesDirectory)/.config/tsaoptions.json'
13-
14-
# CI and PR triggers
2+
- name: _PublishUsingPipelines
3+
value: false
4+
- template: /eng/common/templates-official/variables/pool-providers.yml@self
155
trigger:
166
batch: true
177
branches:
188
include:
19-
- main
20-
- release/*
21-
22-
pr:
23-
autoCancel: false
24-
branches:
25-
include:
26-
- '*'
27-
9+
- main
10+
- release/*
11+
pr: none
2812
resources:
2913
repositories:
3014
- repository: 1ESPipelineTemplates
3115
type: git
3216
name: 1ESPipelineTemplates/1ESPipelineTemplates
3317
ref: refs/tags/release
34-
3518
extends:
3619
template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates
3720
parameters:
38-
pool:
39-
name: NetCore1ESPool-Svc-Internal
40-
image: 1es-windows-2022
41-
os: windows
42-
customBuildTags:
43-
- ES365AIMigrationTooling
4421
sdl:
45-
policheck:
46-
enabled: true
47-
tsa:
48-
enabled: true
22+
createAdoIssuesForJustificationsForDisablement: false
23+
sourceAnalysisPool:
24+
name: $(DncEngInternalBuildPool)
25+
image: 1es-windows-2022
26+
os: windows
4927
stages:
5028
- stage: build
51-
displayName: Build and Test
29+
displayName: Build
5230
jobs:
5331
- template: /eng/common/templates-official/jobs/jobs.yml@self
5432
parameters:
55-
enableMicrobuild: true
5633
enablePublishBuildArtifacts: true
57-
enablePublishUsingPipelines: true
58-
enablePublishTestResults: true
59-
enablePublishBuildAssets: true
34+
enablePublishBuildAssets: false
35+
enablePublishTestResults: false
36+
publishAssetsImmediately: true
37+
isAssetlessBuild: true
6038
enableTelemetry: true
61-
enableSourceBuild: true
62-
helixRepo: dotnet/command-line-api
63-
timeoutInMinutes: 180 # increase timeout since BAR publishing might wait a long time
64-
jobs:
65-
- job: Windows
66-
pool:
67-
name: NetCore1ESPool-Internal
68-
demands: ImageOverride -equals windows.vs2022.amd64
69-
variables:
70-
- ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
71-
# Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT
72-
- group: DotNet-Symbol-Server-Pats
73-
- group: Publish-Build-Assets
74-
- name: _OfficialBuildArgs
75-
value: /p:DotNetSignType=$(_SignType)
76-
/p:TeamName=$(_TeamName)
77-
/p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
78-
/p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)
79-
/p:OfficialBuildId=$(BUILD.BUILDNUMBER)
80-
/p:PublishToSymbolServer=true
81-
/p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
82-
/p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
83-
- name: _PublishUsingPipelines
84-
value: true
85-
# else
86-
- ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
87-
- name: _OfficialBuildArgs
88-
value: ''
89-
strategy:
90-
matrix:
91-
${{ if in(variables['Build.Reason'], 'PullRequest') }}:
92-
Debug:
93-
_BuildConfig: Debug
94-
_SignType: test
95-
_BuildArgs:
96-
97-
Release:
98-
_BuildConfig: Release
99-
# PRs are not signed.
100-
${{ if in(variables['Build.Reason'], 'PullRequest') }}:
101-
_SignType: test
102-
${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
103-
_SignType: real
104-
_BuildArgs: $(_OfficialBuildArgs)
105-
templateContext:
106-
sdl:
107-
binskim:
108-
analyzeTargetGlob: +:f|artifacts\bin\**\*.dll;+:f|artifacts\bin\**\*.exe;-:f|artifacts\bin\**\xunit*.dll;-:f|artifacts\bin\**\verify*.dll;
109-
outputs:
110-
- output: pipelineArtifact
111-
displayName: Upload package artifacts
112-
condition: and(eq(variables['system.pullrequest.isfork'], false), eq(variables['_BuildConfig'], 'Release'))
113-
targetPath: artifacts/packages/
114-
artifactName: artifacts
115-
- output: pipelineArtifact
116-
displayName: Publish Artifact Symbols
117-
condition: and(eq(variables['system.pullrequest.isfork'], false), eq(variables['_BuildConfig'], 'Release'))
118-
targetPath: '$(Build.SourcesDirectory)\artifacts\SymStore\$(_BuildConfig)'
119-
artifactName: 'NativeSymbols'
120-
# WORKAROUND: BinSkim requires the folder exist prior to scanning.
121-
preSteps:
122-
- powershell: New-Item -ItemType Directory -Path $(Build.SourcesDirectory)/artifacts/bin -Force
123-
displayName: Create artifacts/bin directory
124-
steps:
125-
- checkout: self
126-
clean: true
127-
- script: eng\common\cibuild.cmd
128-
-configuration $(_BuildConfig)
129-
-prepareMachine
130-
$(_BuildArgs)
131-
displayName: Build and Publish
132-
133-
- job: Ubuntu
134-
displayName: Ubuntu
135-
pool:
136-
name: NetCore1ESPool-Svc-Internal
137-
demands: ImageOverride -equals 1es-ubuntu-2004
138-
os: linux
139-
strategy:
140-
matrix:
141-
${{ if in(variables['Build.Reason'], 'PullRequest') }}:
142-
Debug:
143-
_BuildConfig: Debug
144-
_SignType: none
145-
Release:
146-
_BuildConfig: Release
147-
_SignType: none
148-
steps:
149-
- checkout: self
150-
clean: true
151-
- bash: |
152-
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
153-
sudo apt-add-repository "deb https://apt.llvm.org/focal/ llvm-toolchain-focal-9 main"
154-
sudo apt-get update
155-
- bash: |
156-
sudo apt-get install cmake clang-9 libicu66 uuid-dev libcurl4-openssl-dev zlib1g-dev libkrb5-dev
157-
- script: eng/common/cibuild.sh
158-
--configuration $(_BuildConfig)
159-
--prepareMachine
160-
displayName: Build
161-
162-
- job: MacOS
163-
displayName: MacOS
164-
pool:
165-
name: Azure Pipelines
166-
image: macOS-latest
167-
os: macOS
168-
strategy:
169-
matrix:
170-
${{ if in(variables['Build.Reason'], 'PullRequest') }}:
171-
Debug:
172-
_BuildConfig: Debug
173-
_SignType: none
174-
_DotNetPublishToBlobFeed: false
175-
Release:
176-
_BuildConfig: Release
177-
_SignType: none
178-
_DotNetPublishToBlobFeed: false
179-
steps:
180-
- checkout: self
181-
clean: true
182-
- script: eng/common/cibuild.sh
183-
--configuration $(_BuildConfig)
184-
--prepareMachine
185-
displayName: Build
186-
187-
- ${{ if notin(variables['Build.Reason'], 'PullRequest') }}:
188-
- template: /eng/common/templates-official/post-build/post-build.yml@self

.vsts-ci.yml

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
1-
variables:
2-
- name: _TeamName
3-
value: DotNetCore
4-
- name: _DotNetArtifactsCategory
5-
value: .NETCore
6-
- name: Codeql.Enabled
7-
value: true
8-
91
# CI and PR triggers
102
trigger:
113
batch: true
124
branches:
135
include:
146
- main
7+
- release/*
158

169
pr:
1710
autoCancel: false
@@ -39,16 +32,12 @@ stages:
3932
pool:
4033
name: NetCore-Public
4134
demands: ImageOverride -equals windows.vs2022.amd64.open
42-
variables:
43-
- name: _OfficialBuildArgs
44-
value: ''
4535
strategy:
4636
matrix:
4737
${{ if in(variables['Build.Reason'], 'PullRequest') }}:
4838
Debug:
4939
_BuildConfig: Debug
5040
_SignType: test
51-
_BuildArgs:
5241

5342
Release:
5443
_BuildConfig: Release
@@ -59,7 +48,6 @@ stages:
5948
- script: eng\common\cibuild.cmd
6049
-configuration $(_BuildConfig)
6150
-prepareMachine
62-
$(_BuildArgs)
6351
displayName: Build and Publish
6452
- task: PublishBuildArtifacts@1
6553
displayName: Upload package artifacts
@@ -93,12 +81,7 @@ stages:
9381
steps:
9482
- checkout: self
9583
clean: true
96-
- bash: |
97-
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
98-
sudo apt-add-repository "deb https://apt.llvm.org/focal/ llvm-toolchain-focal-9 main"
99-
sudo apt-get update
100-
- bash: |
101-
sudo apt-get install cmake clang-9 libicu66 uuid-dev libcurl4-openssl-dev zlib1g-dev libkrb5-dev
84+
- bash: sudo apt-get install cmake clang-9 libicu66 uuid-dev libcurl4-openssl-dev zlib1g-dev libkrb5-dev
10285
- script: eng/common/cibuild.sh
10386
--configuration $(_BuildConfig)
10487
--prepareMachine

Directory.Build.rsp

Lines changed: 0 additions & 1 deletion
This file was deleted.

eng/DotNetBuild.props

Lines changed: 0 additions & 13 deletions
This file was deleted.

eng/Version.Details.props

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ This file should be imported by eng/Versions.props
55
-->
66
<Project>
77
<PropertyGroup>
8-
<!-- dotnet/arcade dependencies -->
9-
<MicrosoftDotNetArcadeSdkPackageVersion>9.0.0-beta.25407.2</MicrosoftDotNetArcadeSdkPackageVersion>
8+
<!-- dotnet/dotnet dependencies -->
9+
<MicrosoftDotNetArcadeSdkPackageVersion>10.0.0-beta.25563.104</MicrosoftDotNetArcadeSdkPackageVersion>
1010
</PropertyGroup>
1111
<!--Property group for alternate package version names-->
1212
<PropertyGroup>
13-
<!-- dotnet/arcade dependencies -->
13+
<!-- dotnet/dotnet dependencies -->
1414
<MicrosoftDotNetArcadeSdkVersion>$(MicrosoftDotNetArcadeSdkPackageVersion)</MicrosoftDotNetArcadeSdkVersion>
1515
</PropertyGroup>
1616
</Project>

eng/Version.Details.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<Dependencies>
3-
<Source Uri="https://github.com/dotnet/dotnet" Mapping="command-line-api" Sha="e17b0d08def649f30aed9c09cf4a2c5741a3c76c" BarId="289695" />
3+
<Source Uri="https://github.com/dotnet/dotnet" Mapping="command-line-api" Sha="93970af2dae989c795efb703be9a25ff95079f25" BarId="290774" />
44
<ProductDependencies>
55
</ProductDependencies>
66
<ToolsetDependencies>
7-
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.25407.2">
8-
<Uri>https://github.com/dotnet/arcade</Uri>
9-
<Sha>e29823691315ed6b3acff20d5bdf3b0be7628283</Sha>
7+
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25563.104">
8+
<Uri>https://github.com/dotnet/dotnet</Uri>
9+
<Sha>93970af2dae989c795efb703be9a25ff95079f25</Sha>
1010
</Dependency>
1111
</ToolsetDependencies>
1212
</Dependencies>

eng/common/CIBuild.cmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
@echo off
2-
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test -sign -pack -publish -ci %*"
2+
powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0Build.ps1""" -restore -build -test -sign -pack -publish -ci %*"

0 commit comments

Comments
 (0)