Lint SCSS stylesheets

• SCSS stylesheets are ignored unless '--scss' flag is specified
• Renamed methods ending in 'css' to more generic 'stylesheets'

Author: hankehly

tools/tasks/seed/css-lint.ts

@@ -5,13 +5,14 @@ import * as gulpLoadPlugins from 'gulp-load-plugins';
 import * as merge from 'merge-stream';
 import * as reporter from 'postcss-reporter';
 import * as stylelint from 'stylelint';
-import { join} from 'path';
+import { join } from 'path';
 
-import { APP_ASSETS, APP_SRC, BROWSER_LIST, CSS_SRC, ENV } from '../../config';
+import { APP_ASSETS, APP_SRC, BROWSER_LIST, CSS_SRC, ENV, DEPENDENCIES, ENABLE_SCSS } from '../../config';
 
 const plugins = <any>gulpLoadPlugins();
 
 const isProd = ENV === 'prod';
+var stylesheetType = ENABLE_SCSS ? 'scss' : 'css';
 
 const processors = [
   doiuse({
@@ -22,35 +23,33 @@ const processors = [
   reporter({clearMessages: true})
 ];
 
-/**
- * Lints the component CSS files.
- */
-function lintComponentCss() {
+function lintComponentStylesheets() {
   return gulp.src([
-      join(APP_SRC, '**', '*.css'),
-      '!' + join(CSS_SRC, '**', '*.css')
-    ])
-    .pipe(isProd ? plugins.cached('css-lint') : plugins.util.noop())
-    .pipe(plugins.postcss(processors));
+    join(APP_SRC, '**', `*.${stylesheetType}`),
+    `!${join(APP_SRC, 'assets', '**', '*.scss')}`,
+    `!${join(CSS_SRC, '**', '*.css')}`
+  ]).pipe(isProd ? plugins.cached('css-lint') : plugins.util.noop())
+    .pipe(ENABLE_SCSS ? plugins.sassLint() : plugins.postcss(processors))
+    .pipe(ENABLE_SCSS ? plugins.sassLint.format() : plugins.util.noop())
+    .pipe(ENABLE_SCSS ? plugins.sassLint.failOnError() : plugins.util.noop());
 }
 
-/**
- * Lints the external CSS files.
- */
-function lintExternalCss() {
-  return gulp.src(getExternalCss().map(r => r.src))
+function lintExternalStylesheets() {
+  return gulp.src(getExternalStylesheets().map(r => r.src))
     .pipe(isProd ? plugins.cached('css-lint') : plugins.util.noop())
-    .pipe(plugins.postcss(processors));
+    .pipe(ENABLE_SCSS ? plugins.sassLint() : plugins.postcss(processors))
+    .pipe(ENABLE_SCSS ? plugins.sassLint.format() : plugins.util.noop())
+    .pipe(ENABLE_SCSS ? plugins.sassLint.failOnError() : plugins.util.noop());
 }
 
-/**
- * Returns the array of external CSS files.
- */
-function getExternalCss() {
-  return APP_ASSETS.filter(d => /\.css$/.test(d.src) && !d.vendor);
+function getExternalStylesheets() {
+  let stylesheets = ENABLE_SCSS ? DEPENDENCIES : APP_ASSETS;
+  return stylesheets
+    .filter(d => new RegExp(`\.${stylesheetType}$`)
+    .test(d.src) && !d.vendor);
 }
 
 /**
  * Executes the build process, linting the component and external CSS files using `stylelint`.
  */
-export = () => merge(lintComponentCss(), lintExternalCss());
+export = () => merge(lintComponentStylesheets(), lintExternalStylesheets());