PHP detecting if list of Request variables are empty()

Question

I'm just looking to optimize the code below. It works, but I want to see if anyone has a shorter way of writing the following condition:

if(
!empty($_REQUEST['shipping_fname']) || 
!empty($_REQUEST['shipping_lname']) || 
!empty($_REQUEST['shipping_address1']) || 
!empty($_REQUEST['shipping_address2']) || 
!empty($_REQUEST['shipping_city']) || 
!empty($_REQUEST['shipping_state']) ||
!empty($_REQUEST['shipping_zip']) ||
!empty($_REQUEST['shipping_country'])){

        /* do stuff in here */

}

As you can see, there are some Request variables I'm checking for. If any of them are not empty, then I'd continue the rest. (for those who have to know, if any shipping info is passed, I'll do validation inside the brackets. Sometimes someone sends just the first, last, and zip.

Again, it works, just wondering if anyone has a shorter methodology.

Corbin · Accepted Answer · 2012-04-01 04:20:30Z

2

It will be worse performance, and really I would probably just stick with your way, but a less burdensome alternative might be:

$arr = array('shipping_fname', 'shipping_lname', '...');
$go = false;
foreach ($arr as $f) { if (!empty($_REQUEST[$f])) { $go = true; break; } }
if ($go) { ... }

You could also do away with the $go if you wanted:

$arr = array('shipping_fname', 'shipping_lname', '...');
foreach ($arr as $f) {
    if (!empty($_REQUEST[$f])) {
        /* do stuff in here */
        break;
    } 
}

answered Apr 1, 2012 at 4:20

Corbin

33.6k7 gold badges73 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

coffeemonitor Over a year ago

you make a good point. If my way is better for performance, I'll just suck it up. But I do like your array() alternative.

Corbin Over a year ago

It's going to barely be slower. Like, maybe a nano second slower. And @tq what in the world are you talking about? How does in_array help here?

Gabriel Santos Over a year ago

in_arra() not work because he check independent key of $_REQUEST

Collectives™ on Stack Overflow

PHP detecting if list of Request variables are empty()

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related