Error unterminated string literal when using php javascript?

Question

I have a file with format

<script src="test.php"></script>

And code in test.php with table test(id, name) with 4000 rows

<?php
$sql = "Select * From test";
$data = array();
$query = mysql_query($sql);
while($row = mysql_fetch_object($query)) {
     $data[] = $row;
}
$str = '';
foreach($data as $row) {
    $str .= $row->name;
}
?>
output('<?php echo $str ?>');

When I run code is error is unterminated string literal, but when repair code with $sql = 'Select * From test order by id limit 100' is no error, how to fix it ?

Ignacio Vazquez-Abrams · Accepted Answer · 2012-03-27 04:38:12Z

3

Never ever ever output PHP values directly.

output(<?php echo json_encode($str) ?>);

answered Mar 27, 2012 at 4:38

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Ignacio Vazquez-Abrams Over a year ago

@OM: It makes sure that the PHP value is converted to a valid JavaScript literal, since all JSON strings are valid JavaScript literals.

OM The Eternity Over a year ago

+1 Oh Great can you please suggest me some good learning resource on this?

Ignacio Vazquez-Abrams Over a year ago

"JSON is a subset of the object literal notation of JavaScript. Since JSON is a subset of JavaScript, it can be used in the language with no muss or fuss."

John Carter · Accepted Answer · 2012-03-27 04:35:30Z

0

You have not closed the script tag properly it has to be like </script>

edited Mar 27, 2012 at 4:35

John Carter

55.7k28 gold badges116 silver badges144 bronze badges

answered Mar 27, 2012 at 4:35

OM The Eternity

16.2k44 gold badges127 silver badges187 bronze badges

Collectives™ on Stack Overflow

Error unterminated string literal when using php javascript?

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related