XML deserialization C# array

Question

I want to import questions for quiz which are in XML file. There are list of questions in XML, and every questions have a list of answers. Can someone help me and tell me where I´m wrong?

XML file "pitanja.xml":

<?xml version="1.0" encoding="utf-8"?>

<Pitanja>

  <Pitanje>

    <TekstPitanja>
      U kojoj državi se nalazi Ajfelova kula?
    </TekstPitanja>

    <Odgovori>
      <Odgovor tacan = "true" > Francuska </Odgovor>
      <Odgovor> Nemačka </Odgovor>
      <Odgovor> Španija </Odgovor>
      <Odgovor> Italija </Odgovor>
    </Odgovori>

  </Pitanje>

  <Pitanje>

    <TekstPitanja>
      U kom gradu se nalazi Big Ben?
    </TekstPitanja>

    <Odgovori>
      <Odgovor tacan = "true" > London </Odgovor>
      <Odgovor> Pariz </Odgovor>
      <Odgovor> Lisabon </Odgovor>
      <Odgovor> Madrid </Odgovor>
    </Odgovori>

  </Pitanje>

  <Pitanje>

    <TekstPitanja>
      Glavni grad Španije je?
    </TekstPitanja>

    <Odgovori>
      <Odgovor tacan = "true" > Madrid </Odgovor>
      <Odgovor> Barselona </Odgovor>
      <Odgovor> Lisabon </Odgovor>
      <Odgovor> Rim </Odgovor>
    </Odgovori>

  </Pitanje>

</Pitanja>

C# code:

[XmlRoot("Pitanja")]
public class Pitanja
{
    [XmlArray("Pitanja")]
    [XmlArrayItem("Pitanje")]
    public List<Pitanje> SvaPitanja { get; set; }

}

public class Pitanje
{
    [XmlElement("TekstPitanja")]
    public string TekstPitanja { get; set; } // Tekst pitanja

    [XmlArray("Odgovori")]
    [XmlArrayItem("Odgovor")]
    public List<Odgovor> Odgovori { get; set; }    // Niz odgovora na pitanje

}

public class Odgovor
{
    [XmlText]
    public string odgovor { get; set; }

    [XmlAttribute]
    public Boolean tacan { get; set; }

}

public void ucitajpitanja()
{
    XmlSerializer dsr = new XmlSerializer(typeof(Pitanja));
    using (System.IO.StreamReader str = new System.IO.StreamReader(@"C:\pitanja.xml"))
    {
        pitanja = (Pitanja)dsr.Deserialize(str);
    }

}

The XmlSerializer is looking for (for example) <ArrayOfOdgovor><Odgovor /><Odgovor /></ArrayOfOdgovor>. It will deserialize an <ArrayOfFoo /> into a Foo[] array or a List<Foo>. But I don't know of a way to get it to do that in the absence of ArrayOfFoo elements in the source. — phoog
– phoog, Commented Mar 26, 2012 at 23:00
Hi Zoran, I suspect you need to decorate the Odgovor.odgovor property with the [XmlText] attribute. — phoog
– phoog, Commented Mar 27, 2012 at 18:02
I add [XmlElement("Odgovor")], but the program still does not work :( — Zoran Đukić
– Zoran Đukić, Commented Mar 27, 2012 at 20:23
when you decorate the odgovor property with [XmlElement("Odgovor")] you're telling the serializer that the Odgovor element contains an Odgovor element of type string, that is, something like this: <Odgovori><Odgovor tacan = "true"><Odgovor>Madrid</Odgovor></Odgovor></Odgovori>. Use [XmlText] to indicate that the odgovor property corresponds to the Text content of the <Odgovor> element; that will match your sample XML data. — phoog
– phoog, Commented Mar 27, 2012 at 20:27

Lubomir Velkov · Accepted Answer · 2012-03-26 23:00:15Z

1

I think you need to wrap the <Odgovor> elements in an additional element - e.g. <Odgovori>

answered Mar 26, 2012 at 23:00

Lubomir Velkov

562 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Zoran Đukić Over a year ago

I have edit XML file & C# code, I also add <Odgovori>, but program still not working, can you help me?

Community · Accepted Answer · 2017-05-23 10:08:40Z

0

Both the Array and the object must have deserializers.

[Serializable]
public class Pitanje {
    public Pitanje() { }

    [XmlAttribute]
    public Boolean tacan { get; set; }
 }

[Serializable]
[XmlRoot("Pitanja", Namespace = "", IsNullable = false)]
public class PitanjaModelList {
   [XmlElementAttribute("Pitanje", Form = XmlSchemaForm.Unqualified)]
   public List<Pitanje> PitanjaList { get; set; }
}

The accepted answer here: Convert XML String to Object will give you how to generate a perfect deserializer for your XML

edited May 23, 2017 at 10:08

CommunityBot

11 silver badge

answered Mar 26, 2012 at 23:11

Hupperware

9791 gold badge6 silver badges15 bronze badges

Comments

000 · Accepted Answer · 2012-03-26 23:43:43Z

0

If you are not restricted to XML Serialization and your objective is simply to read the XML file into your object model, then as an alternative I suggest considering using Linq to XML.

As a sample, your XMLfile could be read into your classes using the following code:

    var result = new Pitanja
    {
        SvaPitanja = (from pitanje in System.Xml.Linq.XDocument.Load(@"C:\pitanja.xml").Root.Elements()
                        select new Pitanje
                        {
                            TekstPitanja = pitanje.Element("TekstPitanja").Value.Trim(),
                            Odgovori = (from odgovor in pitanje.Elements("Odgovor")
                                        let tacanAttribute = odgovor.Attribute("tacan")
                                        select new Odgovor
                                        {
                                            odgovor = odgovor.Value.Trim(),
                                            tacan = tacanAttribute != null && tacanAttribute.Value == "true"
                                        }).ToList()
                        }).ToList()
    };

answered Mar 26, 2012 at 23:43

000

8067 silver badges14 bronze badges

1 Comment

Zoran Đukić Over a year ago

Thank you for help, but I must use XML Deserialization, can you help me with that?

Collectives™ on Stack Overflow

XML deserialization C# array

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related