Trying to get multiple fields validated in Wordpress HTML form using Javascript

Question

I have a two field HTML form for newsletter signup. One field is for first name the other is for email.

I want to validate for both fields being entered, and also for the email address being valid.

I am a relative beginner but have borrowed code, read, researched, watched videos and played around but the best I have been able to achieve is the email validation which I borrowed from www.w3schools.com.

The code I have in my Wordpress header.php file is

<script type="text/javascript">
function validateForm() {
var x=document.forms["newslettersignup"]["bm_email"].value;
var atpos=x.indexOf("@");
var dotpos=x.lastIndexOf(".");

    if (atpos<1 || dotpos<atpos+2 || dotpos+1>=x.length)
    {
    alert("Please enter a valid e-mail address");
    return false;
    }
}
</script>

and the code in the body of the Wordpress pages where I want the form to display is

<form name="newslettersignup" action="/wp-content/plugins/pommo/user/process.php" onsubmit="return validateForm()" method="POST">


Name<input type="text" class="text" style="width: 150px;" name="d[1]" id="d[1]"/>

Email<input type="text" class="text" style="width: 150px;" name="bm_email" id="bm_email" value="" />    

</form>

Whatever I have tried with regards to adding empty field validation for the two fields stops the above working. When I have it just as it is above the alert works perfectly.

Is this a Wordpress thing stopping me from using any of the numerous examples on the net for validating multiple fields?

Thanks for the help.

mrtsherman · Accepted Answer · 2012-01-07 02:43:17Z

1

Wordpress comes with jQuery so I would use that for your form validation instead. jQuery is javascript, but its syntax is easier to follow and it also helps to normalize between different browser versions. Here is an example for your use case:

http://jsfiddle.net/khVtB/

<!-- I added id's so it would be easy to get your form elements. I noticed that you used brackets in your ids. I think this is illegal. Use letters and numbers. -->
<form name="newslettersignup" action="/wp-content/plugins/pommo/user/process.php" onsubmit="return validateForm()" method="POST" id="signupform">
  Name <input type="text" class="text" style="width: 150px;" name="name" id="yourname"/>
  Email <input type="text" class="text" style="width: 150px;" name="email" id="youremail" value="" />    
</form>

$('#signupform').submit(function() {
    if ($('#yourname').val().length == 0) {
        alert('no name');
        return false;
    }

    if ($('#youremail').val().indexOf('@') == -1) {
        alert('bad email');
        return false;
    }

    return true;
});

jQuery also has an awesome validation plugin that will do a lot of these hard things for you.

If you require a non-jQuery solution then I can help with that too, but I think this is probably a better way to go. I can assure you that Wordpress isn't stopping your validation. If anything there may be a script error. You can see this by bringing up your browsers developer tools. For example Firebug in FF, or pressing F12 in Chrome or IE9.

I just reread your question and it looks like you posted your working code and not your non-working code. Hard to debug without seeing the nonworking code. Here is how I would check for empty fields in your javascript solution.

<script type="text/javascript">
function validateForm() {
  var y=document.forms["newslettersignup"]["d"].value; //dont use brackets in names or id's
  var x=document.forms["newslettersignup"]["bm_email"].value;
  var atpos=x.indexOf("@");
  var dotpos=x.lastIndexOf(".");
    if (x.length == 0 || y.length == 0) { return false; }       

    if (atpos<1 || dotpos<atpos+2 || dotpos+1>=x.length)
    {
    alert("Please enter a valid e-mail address");
    return false;
    }
  }
</script>

answered Jan 7, 2012 at 2:43

mrtsherman

40k23 gold badges90 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user1098813 Over a year ago

Thanks, I will have a cup of tea and then do as you say. I must admit I have not got my head around JQuery and how to find out what I can do with it and how to implement it. From what you say it sounds like when I understand it it will be easier than anything I have been trying.

mrtsherman Over a year ago

Here, check this out to just use your original code. Take the time to study up on the basics of jQuery. jsfiddle.net/waxPJ

user1098813 Over a year ago

Thanks, for some reason the form is still processing when I have empty fields even when using the above code you supplied. I have made sure the field names and Ids agree to what you have put above. I will keep working on it.

ericn Over a year ago

This is only client-side validation at best, you'll need server-side validation as well for the reasons mentioned here: coredogs.com/lesson/basic-server-side-validation

Collectives™ on Stack Overflow

Trying to get multiple fields validated in Wordpress HTML form using Javascript

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related