generating a set of javascript code using php

Question

I´m trying using php to generate a set of "{URL.callback}" to use in javascript. By using database. Here is my code:

$sql="select * from search where keywords LIKE '$bb%' ORDER BY keywords ";  

     $result=mysql_db_query($dbname,$sql);

     echo $_GET["callback"] . "({ t:\"$t\", r:[";
    while ( $rs=mysql_fetch_array($result))    {
        $keywords=$rs[keywords];

         echo "" ."\"$keywords\"".","." ";
    }

echo"] })";

This is the code it returns:

({ t:"", r:["example1", "example2", "example3",] })

Everything seemed to be correct except the (,) in the end (after "example3") that I want to get rid. because it´s not correct and can not be use with that.

The question is: How to generate it correctly ? How to get rid the last (,) ?

I also got the good solution from "Indranil", "Billy Moon" Thank you so much for help. — Alex
– Alex, Commented Dec 18, 2011 at 21:14
If you got the solution from @refp, then mark his answer as accepted (that little tick under vote count for his answer) :) — Tadeck
– Tadeck, Commented Dec 18, 2011 at 21:24
Ahh now I know how to mark the answer that was correct. But every answers here are correct...So sad I can mark only one time :S BUt anyway want to say thank you for everybody ! — Alex
– Alex, Commented Dec 18, 2011 at 21:35

Filip Roséen · Accepted Answer · 2011-12-18 20:02:25Z

3

Instead of generating the JSON yourself use json_encode to do the heavy lifting for you.

$keywords = array ();

while ( $rs=mysql_fetch_array($result)) {
  $keywords[] = $rs['keywords'];
}

echo json_encode ($keywords);

Preferred solution

Though if you plan on using json_encode append $keywords to your other set of data and use json_encode on the whole structure.

$json_data = array (
  't' => '',
  'r' => array ()
);

while ( $rs=mysql_fetch_array($result)) {
  $json_data['r'][] = $rs['keywords'];
}

echo "(".json_encode ($json_data).")";

If you'd like to do it yourself there are a few (rather clean) options available, see the snippets below.

Append all retrieved keywords to an array and use join with ',' as delimiter to form a string after your while loop $keyword_array = array ();

while ($rs=mysql_fetch_array($result))    {   
  $keywords=$rs[keywords];

  $keyword_array = "\"$keywords\"";
}

echo join (', ', $keywords);

Use mysql_num_rows before your while loop to get the number of rows in $result, and don't append a , when you are processing the last element.

$n_rows = mysql_num_rows ($result);

for ($i =1; $rs = mysql_fetch_array ($result); ++$i) {
  $keywords=$rs[keywords];

  echo "\"$keywords\"";

  if ($i != $n_rows)
    echo ", ";
}

edited Dec 18, 2011 at 20:02

answered Dec 18, 2011 at 19:33

Filip Roséen

64.2k20 gold badges153 silver badges201 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Alex Over a year ago

OHHHHHHHH MMMMMMMMYYYY GODDDDD I got it :) THANKS SO MUCH

Filip Roséen Over a year ago

@AleksanderPaitoon Please make sure to flag the post as accepted as that will mark your question as solved, and make me tremendously happy ;)

Alex Over a year ago

I´m very new here. I´ve tried to post at the end of my question above that I got the solution from you :))) And I clicked on flag and post that I got the solution from you refp. :))) Thank you so much.

Indranil · Accepted Answer · 2011-12-18 19:49:29Z

1

Try this:

$output = '';
while ( $rs=mysql_fetch_array($result))    {
    $keywords=$rs[keywords];

     $output .= "" ."\"$keywords\"".","." ";
}
$output = substr($output, 0, -2);
echo $output;

edited Dec 18, 2011 at 19:49

answered Dec 18, 2011 at 19:34

Indranil

2,4611 gold badge24 silver badges32 bronze badges

2 Comments

Alex Over a year ago

to Indranil Thanks for help, but i still get the (,) in the end.

Alex Over a year ago

Your answer is also give the solution, I will post for you in the end of my question...Thank you so much for this

Tadeck · Accepted Answer · 2011-12-18 19:40:21Z

0

Solution

Create data structure (multi-dimensional array) within PHP and let json_encode() generate JS data structure.

Example

It could look like this:

$sql="select * from search where keywords LIKE '$bb%' ORDER BY keywords ";  
$result=mysql_db_query($dbname,$sql);

$data = array(
    't' => $t,
    'r' => array(),
);

while ( $rs=mysql_fetch_array($result)) {
    $data['r'][] = $rs['keywords'];
};

and then display it like that:

echo $_GET["callback"].'('.json_encode($data).');';

edited Dec 18, 2011 at 19:40

answered Dec 18, 2011 at 19:35

Tadeck

138k28 gold badges155 silver badges201 bronze badges

11 Comments

Alex Over a year ago

Thanks for your kindness. I actually got the solution from "refp" But I will try yours also wait....

Tadeck Over a year ago

@AleksanderPaitoon: You are welcome. I suggest you should follow his original solution to use json_encode() instead of manually creating JS representation of your data. It will do the job better and simplify your code at the same time.

Alex Over a year ago

Hi although I got the solution already but I want to say thank you that you also help me. I appreciate it. I also tried your code. Seemed like the (,) is gone. But I got the strange encode like this "u0e2b\u0e32\u0e04\u0e21 2553" Maybe I don´t know what to do more...I want to say thank you again :)

Tadeck Over a year ago

@AleksanderPaitoon: This is probably because there were some specials characters inside keywords. You can test how it works eg. here: codepad.org/LQQVQHjw.

Alex Over a year ago

Thanks Tadeck...Your answer is also give me the solution. I will post at the end of my question that you gave me the solution also :) Sorry that I was stupid but after I test it...worked fine...

|

Shoogle · Accepted Answer · 2011-12-18 19:34:24Z

0

Hope this works for you

$sql="select * from search where keywords LIKE '$bb%' ORDER BY keywords ";  

 $result=mysql_db_query($dbname,$sql);

 echo $_GET["callback"] . "({ t:\"$t\", r:[";
$keywords_print = array();
while ( $rs=mysql_fetch_array($result))    {
    $keywords=$rs[keywords];

     $keywords_print[] = "\"$keywords\"";
}
echo implode(",",$keywords_print);
echo"] })";

answered Dec 18, 2011 at 19:34

Shoogle

2061 silver badge14 bronze badges

2 Comments

Alex Over a year ago

Thanks for your kindness. I actually got the solution from "refp" But I will try yours also wait....

Alex Over a year ago

Hi..Thanks for your answer. It also give me the solution... I will post at the end of my question tat you also help me find the solution.

Billy Moon · Accepted Answer · 2011-12-18 20:04:58Z

0

I think the cleanest way, is to create an array of elements, then implode them with a , as separator.

// added initial `"`
echo $_GET["callback"] . "({ t:\"$t\", r:[\"";
while ( $rs=mysql_fetch_array($result))    {
    $keywords=$rs[keywords];
    $arr[] = $keywords;
}
echo implode('", "', $arr);
// added closing `"`
echo "\"] })";

edited Dec 18, 2011 at 20:04

answered Dec 18, 2011 at 19:37

Billy Moon

58.9k27 gold badges148 silver badges244 bronze badges

4 Comments

Alex Over a year ago

Thanks for your kindness. I actually got the solution from "refp" But I will try yours also wait....

Billy Moon Over a year ago

I will, with baited breath :)

Filip Roséen Over a year ago

I can tell you without executing the above that it sadly will not work, you are appending each $keywords to $arr but then using $keywords when you implode, probably a little bit of typo thingie!

Alex Over a year ago

Hi, Billy moon...I found that your answer is also give the solution for me...I will post at the end of my question that you also give the good solution for me.

Collectives™ on Stack Overflow

generating a set of javascript code using php

5 Answers 5

3 Comments

2 Comments

Solution

Example

11 Comments

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

2 Comments

Solution

Example

11 Comments

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related