Lambda function in sorting function

Question

There is this code:

lista = [3,4,5,2,1,6,8,3]
print lista # [3, 4, 5, 2, 1, 6, 8, 3]
lista.sort(cmp=lambda x,y: cmp(y,x)) # sort descending
print lista # [8, 6, 5, 4, 3, 3, 2, 1] -- it is sorted

lista = [3,4,5,2,1,6,8,3]
print lista # [3, 4, 5, 2, 1, 6, 8, 3]
lista.sort(cmp=lambda x,y: y > x) # sort descending
print lista # [3, 4, 5, 2, 1, 6, 8, 3] -- nothing happens

Why does the lambda function in the second block not sort the numbers?

I know that, but it is not the case in above example

scdmb
– scdmb

2011-12-12 18:24:31 +00:00
Commented Dec 12, 2011 at 18:24 — scdmb
– scdmb, Commented Dec 12, 2011 at 18:24
Don't use the cmp argument. Use key.

Daniel Roseman
– Daniel Roseman

2011-12-12 18:36:52 +00:00
Commented Dec 12, 2011 at 18:36 — Daniel Roseman
– Daniel Roseman, Commented Dec 12, 2011 at 18:36

NPE · Accepted Answer · 2011-12-12 18:24:14Z

21

The second example doesn't work because the function you're giving it isn't a valid comparator.

A valid comparator is supposed to

return a negative, zero or positive number depending on whether the first argument is considered smaller than, equal to, or larger than the second argument.

The function lambda x,y: y > x doesn't fulfil this contract.

answered Dec 12, 2011 at 18:24

NPE

503k114 gold badges970 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Andrew Clark · Accepted Answer · 2011-12-12 18:26:58Z

8

A cmp function needs to return a negative or positive number to indicate which element should go first (unless they are equal, then return 0). Your cmp function of y > x will only return 0 or 1. Try changing it to the following:

lista.sort(cmp=lambda x,y: (y > x) - (y < x))

I took this from the Python 3 docs:

If you really need the cmp() functionality, you could use the expression (a > b) - (a < b) as the equivalent for cmp(a, b).

answered Dec 12, 2011 at 18:26

Andrew Clark

210k36 gold badges285 silver badges310 bronze badges

Comments

Gevious · Accepted Answer · 2011-12-12 18:29:28Z

2

x < y returns True or False, while cmp returns 1 and -1. This code works:

lista.sort(cmp=lambda x,y: 1 if x<y else -1)

answered Dec 12, 2011 at 18:29

Gevious

3,2803 gold badges23 silver badges43 bronze badges

1 Comment

Pretzel Over a year ago

actually, your "<" should be a ">"

Collectives™ on Stack Overflow

Lambda function in sorting function

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related