Java: Getting Concurrent Modification Exception when modifying ArrayList

Question

So I'm writing a program which keeps a track of various documents like e-mails, memos, and reports. The documents are stored in an ArrayList called "active" by default, but the user has the option of transferring them to another ArrayList called "archive", using an identification code("docId").

I thought that this would be pretty straightforward but I'm running into this error and would appreciate your help in resolving it. Here's my code:

private static ArrayList active = new ArrayList();
private static ArrayList archive = new ArrayList(); 

public static void archiveDocument(double docId)
{       
    if(active.isEmpty() == true)
    {
        System.out.println(Messages.emptyList());
    }
    else
    {
        for(Object a : active)
        {
            Document doc = (Document) a;

            if(doc.getIdNum() == docId)
            {
                archive.add(a);
                active.remove(a);

                System.out.printf(Messages.enteredIntoArchive(), doc.getIdNum());
            }
            else System.out.println(Messages.notFound());
        }
    }
}

erickson · Accepted Answer · 2011-11-29 01:09:23Z

3

If you want to remove during iteration, use an explicit iterator:

Iterator i = active.iterator();
while (i.hasNext()) {
  Document doc = (Document) i.next();
  if (doc.getIdNum() == docId) {
    archive.add(doc);
    i.remove();
    System.out.printf(Messages.enteredIntoArchive(), doc.getIdNum());
  }
  else
    System.out.println(Messages.notFound());
}

answered Nov 29, 2011 at 1:09

erickson

271k59 gold badges406 silver badges502 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David V · Accepted Answer · 2011-11-29 00:56:08Z

3

You are trying to change the list while iterating over its enumerator.

for(Object a : active)

This starts an enumeration

active.remove(a);

You modify it here.

One easy fix is to copy the list before enumerating over it and then enumerate over the copy.

ArrayList activeCopy = new ArrayList(active);
for(Object a : activeCopy)
{
...
}

answered Nov 29, 2011 at 0:56

David V

11.7k5 gold badges46 silver badges70 bronze badges

Comments

Anne · Accepted Answer · 2011-11-29 01:10:26Z

2

You can't modify the enumeration while reading at same time. You need to make a copy of the ArrayList. Sometimes I shortcut by converting the ArrayList into an array[].

public void archiveDocument(double docId) {
        if (active.isEmpty() == true) {
            System.out.println(Messages.emptyList());
        } else {
            for (Object a : active.toArray(new Object[0])) {
                Document doc = (Document) a;

                if (doc.getIdNum() == docId) {
                    archive.add(a);
                    active.remove(a);

                    System.out.printf(Messages.enteredIntoArchive(), doc
                            .getIdNum());
                } else
                    System.out.println(Messages.notFound());
            }
        }
    }

edited Nov 29, 2011 at 1:10

Anne

27.2k9 gold badges66 silver badges71 bronze badges

answered Nov 29, 2011 at 1:03

vcetinick

2,0272 gold badges20 silver badges43 bronze badges

Collectives™ on Stack Overflow

Java: Getting Concurrent Modification Exception when modifying ArrayList

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related