Passing multiple Eval() to a JavaScript function from ASPX

Question

I am trying to pass multiple Eval() arguments to a JavaScript function from an .aspx file, but I keep getting compiler errors. I am new to JavaScript and have never really used Eval() before. Where am I going wrong?

NB: The line shown below is actually all on one line, but is wrapped here for clarity:

<asp:LinkButton runat="server" Text='<%#Eval("Title")%>'
    OnClick='javascript:ShowEventDetails'
    CommandArgument='<%#
        Eval("EventID").ToString()          & Eval("Title").ToString() &
        Eval("Location").ToString()         & Eval("StartTime").ToString() &
        Eval("Description").ToString()      & Eval("Link").ToString() &
        Eval("ContactFirstName").ToString() & Eval("ContactLastName").ToString() &
        Eval("ContactEmail").ToString()     & Eval("InsertionTime").ToString() &
        Eval("EventAdmin").ToString()%>); ' />

Are there better ways of doing this? If so, what are they?

Let me know if the answer I gave helped you.

George Stocker
– George Stocker

2009-07-29 18:13:28 +00:00
Commented Jul 29, 2009 at 18:13 — George Stocker
– George Stocker, Commented Jul 29, 2009 at 18:13

Rex M · Accepted Answer · 2009-04-14 18:06:01Z

1

OnClick is a property on the control which expects a reference to an event handler method. Putting JavaScript in the OnClick property will not work.

If you want to execute arbitrary JavaScript when the button is clicked, use OnClientClick. I presume you want to pass the evals into ShowEventDetails as arguments (formatted for readability):

<asp:LinkButton ID="LinkButton1" runat="server" Text='<%# Eval("Title")%>' 
    OnClientClick='ShowEventDetails("<%# Eval("EventID").ToString() %>",
        "<%# Eval("Title").ToString() %>",
        "<%# Eval("Location").ToString() %>",
        "<%# Eval("StartTime").ToString() %>",
        "<%# Eval("Description").ToString() %>",
        "<%# Eval("Link").ToString() %>",
        "<%# Eval("ContactFirstName").ToString() %>",
        "<%# Eval("ContactLastName").ToString() %>",
        "<%# Eval("ContactEmail").ToString() %>",
        "<%# Eval("InsertionTime").ToString() %>",
        "<%# Eval("EventAdmin").ToString() %>");' />

Essentially you are constructing one long string:

ShowEventDetails('123','Event Title','New York' ... etc ...

Which is executed in JS when the LinkButton is clicked.

edited Apr 14, 2009 at 18:06

answered Apr 14, 2009 at 15:31

Rex M

144k34 gold badges292 silver badges315 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Dhruv Over a year ago

Thank you for your response. The compiler now complains that the server tag is not well formatted.

Rex M Over a year ago

@Dhruv OK, this method of constructing arguments is a bit error-prone since there are so many places for syntax typos. I've redone it and verified it works.

Dhruv Over a year ago

@Rex Thanks. This is what I get from the page source. Do you still think we can work around this? <a onclick="ShowEventDetails("<%# Eval("EventID").ToString() %>", "<%# Eval("Title").ToString() %>", and so on.

George Stocker · Accepted Answer · 2009-07-29 16:28:02Z

0

The best way to do this is to set the OnClientClick property in the code-behind, like so:

LinkButton lb = new LinkButton(); //Instantiate the linkbutton wherever you need to

Once you do, use String.Format to put your items into the OnClientClick property.

lb.OnClientClick = String.Format("javascript:ShowEventDetails
( '{0}', '{1}', '{2}', '{3}', '{4}', '{5}', '{6}', '{7}', '{8}', '{9}', '{10}');", 
  EventID.ToString(), Title.ToString(), Location.ToString(), StartTime.ToString(), 
  Description.ToString(), Link.ToString(), ContactFirstName.ToString(),
  ContactLastName.ToString(), ContactEmail.ToString(), InsertionTime.ToString(),
  EventAdmin.ToString() );

edited Jul 29, 2009 at 16:28

answered Jul 29, 2009 at 16:02

George Stocker

58k29 gold badges184 silver badges239 bronze badges

Comments

Bipinkrishna · Accepted Answer · 2016-01-14 17:13:45Z

0

Another way to pass multiple parameter from aspx client, sample code is given below

Use two double quotes (+ ",""" + Eval("xxx").ToString() + """) if you want to pass a string parameter

OnClientClick='<%#"javascript:return OpenDetailsPage(" + Eval("xxx").ToString() + ",""" + Eval("xxx").ToString() + """," _
                                                + Eval("xxx").ToString() + "," + Eval("xxx").ToString() + "," + Eval("xxx").ToString() + "," _
                                                + Eval("xxx").ToString() + ",""" + Eval("xxx").ToString() + """,this);"%> '

answered Jan 14, 2016 at 17:13

Bipinkrishna

11 bronze badge

Comments

zakk616 · Accepted Answer · 2022-09-29 19:02:56Z

0

Eval is Evil try this Life Saving Code

onClick=='<%# string.Format("javascript:ShowEventDetails({0},{1},{2});return false;", Eval("Title"), Eval("Location"), Eval("StartTime")) %>'

answered Sep 29, 2022 at 19:02

zakk616

1,57210 silver badges15 bronze badges

Collectives™ on Stack Overflow

Passing multiple Eval() to a JavaScript function from ASPX

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related