ASP.Net MVC 3 - instantiate data context class in BaseController

Question

When adding a controller in ASP.Net MVC 3 using "Controller with Read/Write actions and views, using EntityFramework" as template, it generates a class as follows:

namespace Project.Controllers
{ 
    public class Default1Controller : Controller
    {
        private ProjectEntities db = new ProjectEntities();

        ...
    }
}

Now, I would like to know if it would be a good practice to change this so that my Controller would inherit a custom base controller that would instantiate ProjectEntities. It would look as follows:

BaseController:

namespace MatchesHorsConcours.Controllers
{
    public class BaseController : Controller
    {
        protected MatchesEntities db = new MatchesEntities();
        ...
    }
}

Other controllers:

namespace Project.Controllers
{ 
    public class Default1Controller : BaseController
    {
    ...
    }
}

It's better practice to use Dependency Injection. There are a number of libraries out there to do this. To name a few, Ninject, Castle Windsor or Autofac — David Fox
– David Fox, Commented Aug 17, 2011 at 17:11

Anonymous Apple · Accepted Answer · 2011-08-17 17:16:22Z

2

This technique is useful when you need logic in your master page (for example, to dynamically render menu options). Read about this here: http://www.asp.net/mvc/tutorials/passing-data-to-view-master-pages-cs

However, in general this is not a good technique. I would recommend using dependency injection (Ninject works well with MVC and is easy to implement)

answered Aug 17, 2011 at 17:16

Anonymous Apple

1,3812 gold badges10 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 10:34:23Z

1

No absolutely not. It makes totally untestable. Please use repository pattern and constructor injection if possible: Repository Pattern vs DAL

edited May 23, 2017 at 10:34

CommunityBot

11 silver badge

answered Aug 17, 2011 at 17:12

Tae-Sung Shin

20.7k34 gold badges144 silver badges248 bronze badges

Collectives™ on Stack Overflow

ASP.Net MVC 3 - instantiate data context class in BaseController

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related