How to divide string into substring in javascript

Question

I am new to javascript and i am trying to divide and store a part of a string

this.chartIdSelector="Bulletsavings-140"
this.opportunityId = +this.chartIdSelector.substring(this.chartIdSelector.lastIndexOf('-') + +1);

This returns 140 back but if i include any alphabet it returns NAN

this.chartIdSelector="Bulletsavings-14av0"
this.opportunityId = +this.chartIdSelector.substring(this.chartIdSelector.lastIndexOf('-') + +1);

NAN

Unary plus (+) will try to convert the final value to a number. Since in the second example the final value contains a character, it will return NaN (Not a Number) — codeVerine
– codeVerine, Commented Jul 26, 2021 at 10:56

mplungjan · Accepted Answer · 2021-07-26 11:06:57Z

3

As I already commented, remove the unary plus, also no need to + +1

let chartIdSelector="Bulletsavings-14av0"
let opportunityId = chartIdSelector.substring(chartIdSelector.lastIndexOf('-') +1);

console.log(opportunityId)

And in your case, just use split:

Here assuming only one dash in the string

let chartIdSelector = "Bulletsavings-140"
let opportunityId = chartIdSelector.split("-")[1] 
console.log(opportunityId)
chartIdSelector="Bulletsavings-14av0"
opportunityId = chartIdSelector.split("-")[1] 
console.log(opportunityId)

Possibly more than one dash (but ID still at the end) - use pop:

let chartIdSelector = "Bullet-savings-140"
let opportunityId = chartIdSelector.split("-").pop()
console.log(opportunityId)
chartIdSelector="Bullet-savings-14av0"
opportunityId = chartIdSelector.split("-").pop()
console.log(opportunityId)

edited Jul 26, 2021 at 11:06

answered Jul 26, 2021 at 10:48

mplungjan

180k29 gold badges183 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Marco Jr · Accepted Answer · 2021-07-26 10:48:11Z

0

Rahul !

Just remove the plus sign. Keep as

this.chartIdSelector="Bulletsavings-140"
this.opportunityId = this.chartIdSelector.substring(this.chartIdSelector.lastIndexOf('-') + +1);

answered Jul 26, 2021 at 10:48

Marco Jr

6,84811 gold badges56 silver badges95 bronze badges

Comments

mplungjan · Accepted Answer · 2021-07-26 10:58:30Z

0

You can use split

Here I use slice(-1) to get the last element from the array of the split, in case there are more than one dash in the string

let chartIdSelector = "Bulletsavings-14av0"
let opportunityId = chartIdSelector.split('-').slice(-1)[0] 


console.log(opportunityId)

edited Jul 26, 2021 at 10:58

mplungjan

180k29 gold badges183 silver badges246 bronze badges

answered Jul 26, 2021 at 10:47

muhammed ikinci

7472 gold badges6 silver badges19 bronze badges

3 Comments

muhammed ikinci Over a year ago

For getting last element from array

muhammed ikinci Over a year ago

Oh ok, sorry about that, and thank you, next time I will watch out for that.

mplungjan Over a year ago

Good idea to consider such cases. I chose split("-").pop() since it is easier to read

Collectives™ on Stack Overflow

How to divide string into substring in javascript

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related