VBA code not entering else if and end if loop

Question

I have the below loop written, however I am having issues with the code entering the else if loop and to have the loop until (end if) the ranges equal each other. Essentially I want the loop to add 2 to the cells that contain "Corporates" first and afterwards add 1 to the cells that have a the number 2.

Dim x As Long
Dim V As Variant

V = Cells(Rows.Count, 1).End(xlUp).Row
JV = Range("J" & Rows.Count).End(xlUp).Row
For x = 1 To V
If Cells(x, 2).Value = "Corporates" Then
Cells(x, 7).Value = Cells(x, 7).Value + 1
    
ElseIf Cells(x, 12).Value < "3%" And Cells(x, 2).Value = "Corporates" Then
Cells(x, 7).Value = Cells(x, 7).Value + 1
    
End If
Range("J" & JV + 3).Value = Range("J" & JV + 2).Value
 
Next x
End Sub

ElseIf won't trigger since it has the same requirement as the If. So either the If triggers, or none of them. Cells(x, 12).Value < "3%" also probably won't behave as you'd expect since the "3%" is a string, and not a numerical value. — Christofer Weber
– Christofer Weber, Commented Jun 30, 2021 at 20:46

BigBen · Accepted Answer · 2021-06-30 20:44:58Z

1

Use a nested If instead of ElseIf

I'm guessing that < "3%" should be < 0.03 ("3%" is text, not a number).

If Cells(x, 2).Value = "Corporates" Then
    If Cells(x, 12).Value < 0.03 Then
        Cells(x, 7).Value = Cells(x, 7).Value + 2
    Else
        Cells(x, 7).Value = Cells(x, 7).Value + 1
    End If
End If

answered Jun 30, 2021 at 20:44

BigBen

50.4k7 gold badges29 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

VBA code not entering else if and end if loop

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related