Single array argument versus multiple arguments in PHP

Question

public function setSomething($what){
  $this->something = $what;
}

...

$obj->setSomething(array('aaa', 'bbb', 'ccc'));

or

public function setSomething(){
  $this->something = array_values(func_get_args());
}

...

$obj->setSomething('aaa', 'bbb', 'ccc');

Which method would you use and why?

ps: the second one could also be used to emulate keys I think, if you give out argument names:

$obj->setSomething($key1 = 'aaa', $key = 'bbb', $key = 'ccc');

How are you getting the data that you're passing to the setter? — Dogbert
– Dogbert, Commented Jul 6, 2011 at 21:46
In general, use a function signature that conveys your API to the developer — Gordon
– Gordon, Commented Jul 6, 2011 at 22:20

Andrew · Accepted Answer · 2011-07-06 21:47:58Z

2

I usually only use an array if multiple arguments are optional. For example, if I have a report that can take a company ID, an employee ID, or both. I won't have function report ($CompanyID = null, $EmployeeID = null), I'll do function report($array) and then inside the function, do if (isset($array['company_id']))... etc.

If you think you need to use an array because you have too many arguments, that's probably a sign that the function is too complicated and needs to be split up.

Edit: Note that this is more a general answer, as I'm not sure how it applies to your setter issue, since logically a setter should only take one argument. In your situation, if your $this->something expects an array, give it an array, rather than arguments that you have to then turn into an array.

answered Jul 6, 2011 at 21:47

Andrew

5,2336 gold badges45 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Single array argument versus multiple arguments in PHP

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related