String or StringBuilder for SQL query

Question

I am working on my project and now I am having doubts about SQL query; is it okay to put the whole query in the String or it is better practice to use StringBuilder even though the query is static (it doesn't contain any variable)

private void createTheExpectedData() throws SQLException {
        String query = "SELECT products.productname, orderdetails.quantityordered, orderdetails.priceEach "
                + "FROM orderdetails "
                + "INNER JOIN products "
                + "ON orderdetails.productcode = products.productcode";
        resultSet = db.testClassQuery(query);

Try and profile both. Do you see a difference? If yes, that's your answer. If not, that's an answer as well. — Federico klez Culloca
– Federico klez Culloca, Commented Apr 27, 2020 at 14:56
I think java compiler is smart enough to optimize usage of string constants without any action from your side. — Ivan
– Ivan, Commented Apr 27, 2020 at 15:01

Elliott Frisch · Accepted Answer · 2020-04-27 15:01:04Z

1

They would be equivalent here, because Java performs String concatenation with StringBuilder (since Java 5 anyway). However, since the query is static I would suggest moving it to a static constant. Then you really don't have to worry if that concatenation takes too much time. Or about creating that temp String instance on every invocation.

private static final String CREATE_QUERY = "SELECT products.productname, "
            + "orderdetails.quantityordered, orderdetails.priceEach "
            + "FROM orderdetails "
            + "INNER JOIN products "
            + "ON orderdetails.productcode = products.productcode";

private void createTheExpectedData() throws SQLException {
    resultSet = db.testClassQuery(CREATE_QUERY);
    // ...
}

answered Apr 27, 2020 at 15:01

Elliott Frisch

202k20 gold badges166 silver badges265 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

String or StringBuilder for SQL query

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related