Filtering a JavaScript object with nested structure

Question

let data = [
    {
        title: 'aa',
        releases: [
            { version: '1', owner: 'john'},
            { version: '2', owner: 'bob'}
        ]
    },
    {
        title: 'bb',
        releases: [
            { version: '1', owner: 'john'},
            { version: '2', owner: 'jack'}
        ]
    },
    {
        title: 'cc',
        releases: [
            { version: '1', owner: 'doo'},
            { version: '2', owner: 'park'}
        ]
    },
]

I have an array of objects that looks like above.

I am trying to filter the objects by the owner inside the releases array.

What I've tried is

data.filter(item => 
        ['john'].some(
            item.releases.some(
                obj=>obj.owner.toLowerCase().includes(['john'])
            )
        )
    )

I used an array of string(s) to have multiple search queries in the future. But this gives me an error

Uncaught TypeError: true is not a function

How can I solve this?

The result should be all objects that have john as an owner in any of its releases array

some takes a function; you're passing the result of a separate some call. — Heretic Monkey
– Heretic Monkey, Commented Sep 9, 2019 at 19:46
Possible duplicate of Filter nested array in object array by array of values — Heretic Monkey
– Heretic Monkey, Commented Sep 9, 2019 at 19:55

Alex Wayne · Accepted Answer · 2019-09-09 19:55:48Z

2

That ['john'].some( call isn't really helping. You have the logic already without that.

You are getting that error because you are passing the result of some() (which returns a boolean) to some() (which expect a function).

Also, when asking if a string includes a string, you should pass in a string, not an array.

const filteredData = data.filter(item => 
    item.releases.some(
        obj => obj.owner.toLowerCase().includes('john')
    )
)

edited Sep 9, 2019 at 19:55

answered Sep 9, 2019 at 19:47

Alex Wayne

188k52 gold badges328 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Pointy Over a year ago

It should be noted that data.filter() returns a new array, and won't change the original data array.

Karl-André Gagnon Over a year ago

I'm also fairly certain that String.includes() first argument only accepts strings.

Alex Wayne Over a year ago

@Karl-AndréGagnon You would think, but it does actually work as is. Though, probably via string coercion. Answer updated.

Karl-André Gagnon Over a year ago

@AlexWayne Indeed, you are right. Don't you like untyped languages? :)

Code Maniac · Accepted Answer · 2019-09-09 19:54:06Z

0

some expects a function not value, in the outer most some you're just passing the value you need to pass function instead

data.filter(item =>  
        ['john'].some( () =>      //  <--- function
            item.releases.some(
                obj=>obj.owner.toLowerCase().includes('john')
            )
        )
    )

Infact you don't need outer some

data.filter(item =>  
     item.releases.some(
       obj=>obj.owner.toLowerCase().includes('john')
    )
)

edited Sep 9, 2019 at 19:54

answered Sep 9, 2019 at 19:47

Code Maniac

37.9k5 gold badges44 silver badges65 bronze badges

1 Comment

Code Maniac Over a year ago

@Pointy i just copied OP's code to show what is the real problem in code, add a version without some too

Umer Farooqui · Accepted Answer · 2019-09-09 20:11:57Z

0

You can try this:

let data = [
    {
        title: 'aa',
        releases: [
            { version: '1', owner: 'john'},
            { version: '2', owner: 'bob'}
        ]
    },
    {
        title: 'bb',
        releases: [
            { version: '1', owner: 'john'},
            { version: '2', owner: 'jack'}
        ]
    },
    {
        title: 'cc',
        releases: [
            { version: '1', owner: 'doo'},
            { version: '2', owner: 'park'}
        ]
    },
];

var result = data.filter(x => x.releases.some(rls => rls.owner.toLowerCase().includes(['john'])));

console.log(result);

answered Sep 9, 2019 at 20:11

Umer Farooqui

3072 silver badges7 bronze badges

Comments

3limin4t0r · Accepted Answer · 2019-09-09 21:05:12Z

If the intent is to check for a single name you can negate this answer. However if the intent of the question is to check for multiple names you can fix your code in the following way.

The issue is that you're providing a true/false value to the first some call, this should be a function.

const names = ['john'];
data.filter(item =>
  names.some(name => // added `name =>`
    item.releases.some(release =>
      release.owner.toLowerCase().includes(name) // changed `['john']` into `name`
    )
  )
);

However, you can also achieve the same functionality with less iterations by using an regex.

// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#Escaping
const escapeRegExp = string => string.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');

const names = ['john'],
      pattern = names.map(escapeRegExp).join("|"),
      regex = new RegExp(pattern, "i"); // i = ignore case (removing the need of toLowerCase)

data.filter(item => item.releases.some(release => release.owner.match(regex)));

Collectives™ on Stack Overflow

Filtering a JavaScript object with nested structure

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related