Problem when inserting multiple data ASP.NET MVC

Question

I am having trouble when inserting multiple records. When I try to insert 2 records the debugger shows the count of 2 but it only saves 1 record.

This is my code in my manager class

public void Create(IEnumerable<CollectionModel> p )
{
    collection module = new collection();
    foreach (var asa in p)
    {               
        module.AccountId = 1;
        module.Amount = asa.Amount;
        module.NameSou = asa.NameSou;
        module.Date = asa.Date;
        module.CreatedDatetime = DateTime.Now;
        module.UpdatedDatetime = DateTime.Now;

        _context.collection.Add(module);
    }
    _context.SaveChanges();
}

Try adding _context.collection.Add(module); inside for loop — Tushar Gupta
– Tushar Gupta, Commented Mar 19, 2019 at 3:32
thank you for your help. I just edited my question. Its still saved 1 data — pold
– pold, Commented Mar 19, 2019 at 3:36

Rahul Raut · Accepted Answer · 2019-03-19 04:19:36Z

1

Small Correction in your code. You are creating one module and updating the same every time. So it will always save the list of last item in your case list of last item of p.

 public void Create(IEnumerable<CollectionModel> p )
 {
   foreach (var asa in p)
     {   
       collection module = new collection();            
       module.AccountId = 1;
       module.Amount = asa.Amount;
       module.NameSou = asa.NameSou;
       module.Date = asa.Date;
       module.CreatedDatetime = DateTime.Now;
       module.UpdatedDatetime = DateTime.Now;

      _context.collection.Add(module);
    }
   _context.SaveChanges();
 }

edited Mar 19, 2019 at 4:19

answered Mar 19, 2019 at 4:10

Rahul Raut

6436 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

pold Over a year ago

Do i need to do a List or IEnumerable of Collection Module?

Rahul Raut Over a year ago

Sorry I din't get your question?

pold Over a year ago

Do i need to make a ` List<collection> module = new List<collection>();` instead of collection module = new collection();?

Rahul Raut Over a year ago

No not list of collection just new collection, as foreach loop iterates every time, it will create a new instance of collection and it will be added to context collection.

Ashiquzzaman · Accepted Answer · 2019-03-19 04:34:49Z

1

Entity Framework offers two methods to insert records into database. Add() method allows to insert a single entity. AddRange() method inserts an IEnumerable collection. You can find more information from here.

Example:

 public void Create(IEnumerable<CollectionModel> args )
 {
    var modules = args.Select(asa=> new collection{
       AccountId = 1,
       Amount = asa.Amount,
       NameSou = asa.NameSou,
       Date = asa.Date,
       CreatedDatetime = DateTime.Now,
       UpdatedDatetime = DateTime.Now
      }).ToList(); 
    _context.collection.AddRange(modules);
   _context.SaveChanges();
}

edited Mar 19, 2019 at 4:34

answered Mar 19, 2019 at 3:59

Ashiquzzaman

5,3144 gold badges30 silver badges40 bronze badges

5 Comments

Rahul Raut Over a year ago

Is there any exception or the same result?

pold Over a year ago

It works! Thank you! I just remove all the semi colon :) Thank you

pold Over a year ago

hi @Ashiquzzaman just one more thine, if i want to add some data to other table, i will just do the same? right?

Ashiquzzaman Over a year ago

@PaulVincentDoroyan Yes. You can do. and one more suggestion please spend some time to read my provided link.

pold Over a year ago

im getting 500 internal server error when I try to save 2 datas in two tables

Collectives™ on Stack Overflow

Problem when inserting multiple data ASP.NET MVC

2 Answers 2

4 Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related