Retrieve data with foreach from return array function

Question

I'm having troubles with my function and how to retrieve the data. Here is what i got.

public function getImages()
{
    $array = array();

    //Test query
    $query = $this->connect()->query("SELECT * from user");
    while ($row = $query->fetch()) {
        $array[] = $row;
        return $array;
    }
}

Now I'm calling this function but i can not use foreach to access the array.

include "header.html";
include "autoload.php";
spl_autoload_register('my_autoloader');

$users = new User;
$users->getImages();

foreach ($users as $value) {
  echo $value["username"];
}

What am I doing wrong? I'm only getting one result but there are many in my database. Or if i call the $array in foreach it says undefined.

What is the code doing wrong? I assume you’re only getting one result. Look where your return statement is. And please always explain exactly what is wrong with the code so we don’t have to guess — Sami Kuhmonen
– Sami Kuhmonen, Commented Mar 3, 2019 at 13:01
I literally figured it out after I saw your comment! You are great! Thanks — svrdoljak
– svrdoljak, Commented Mar 3, 2019 at 13:06

David · Accepted Answer · 2019-03-03 13:02:50Z

1

A couple things. First, your function is only ever returning an array with one element in it. If you want to finish populating the array, don't return until after the loop:

while ($row = $query->fetch()) {
    $array[] = $row;
}
return $array;

And second, you're trying to iterate over the object which has the function, not the value returned from the function. Get the return value and iterate over that:

$userDAO = new User;
$users = $userDAO->getImages();

foreach ($users as $value) {
    echo $value["username"];
}

answered Mar 3, 2019 at 13:02

David

221k42 gold badges245 silver badges337 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Prakhar · Accepted Answer · 2019-03-03 13:14:32Z

1

You just need to put the return statement out of the while loop.

public function getImages() { 
      $array = array(); //Test query
      $query = $this->connect()->query("SELECT * from user"); 
       while ($row = $query->fetch()) { 
            $array[] = $row; 
        }
        return $array;
  }

answered Mar 3, 2019 at 13:14

Prakhar

213 bronze badges

Collectives™ on Stack Overflow

Retrieve data with foreach from return array function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related