Arduino Continue with for-loop only when button is pressed

Question

I have an int array of melodies. If i press the button it plays the whole song but if i put a break after the delay, than it just reset the i. How do i make it so that only after another button-press it continues? (i'm still a newbie at this sorry and thanks in advance)

int buttonPin = 12;

void setup() 
{
 // put your setup code here, to run once:

   pinMode(buttonPin, INPUT);
}


void loop() 
{
 // put your main code here, to run repeatedly:

  int buttonState = digitalRead(buttonPin);

  for(int i = 0; i < sizeof(mariomelody); i++)
  {
    if(buttonState == HIGH)
    {
      tone(8, mariomelody[i], 70); 
      delay();
    }  
  }
}

This might not be an answer but your button might be high as default. Post code where you set up digital pin. — user5550963
– user5550963, Commented Feb 13, 2019 at 13:24
@Gox If it was, than the melody would be played immediately... — zhrgci
– zhrgci, Commented Feb 13, 2019 at 13:28
i dont have arduino with me, but my advice is always put this digitalWrite(buttonPin, LOW); in setup. also try putting it before if statement. — user5550963
– user5550963, Commented Feb 13, 2019 at 13:32

theGtknerd · Accepted Answer · 2019-02-13 13:34:44Z

1

Stop the loop while the button press is still held in:

int buttonPin = 12;

void setup() 
{
 // put your setup code here, to run once:

   pinMode(buttonPin, INPUT);
}


void loop() 
{
 // put your main code here, to run repeatedly:

  int buttonState = digitalRead(buttonPin);

  for(int i = 0; i < sizeof(mariomelody); i++)
  {
    if(buttonState == HIGH)
    {
      tone(8, mariomelody[i], 70); 
      delay();
    }  
    while(digitalRead(buttonPin) == HIGH)
    {
    // wait until the button is released
    }
    while(digitalRead(buttonPin) == LOW)
    {
    //wait until the button is pressed again
    }
  }
}

answered Feb 13, 2019 at 13:34

theGtknerd

3,8131 gold badge17 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rodrigo · Accepted Answer · 2019-02-13 13:34:53Z

I'm guessing that you want to play the melody while the button is pressed, and stop if the button is released.

Then it would be something like:

int i = 0;
void loop() 
{
    if(digitalRead(buttonPin) == HIGH)
    {
      tone(8, mariomelody[i], 70); 
      i = (i + 1) % sizeof(mariomelody);
      delay();
    }  
}

To avoid resetting the position to the begin of the melody you need i to be a global variable.

If you want the button to switch on and off the melody you'll need another global variable playing:

bool playing = false;
void loop()
{
    if(digitalRead(buttonPin) == HIGH)
    {
        playing = !playing;
        while (digitalRead(buttonPin) == HIGH)
             ; //wait for release
    }
    if (playing) {
        //the rest is the same
    }
}

Collectives™ on Stack Overflow

Arduino Continue with for-loop only when button is pressed

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related