C# List loop within a loop?

Question

I'm working on a class project and here is what I have so far. I know the code returns true when it finds a match but I want it to keep looping until no more instances are found.

I've looked at numerous sites on for/while loops but I can't seem to get the syntax correct and/or it doesn't work when applying the logic.

public bool Remove(T toRemove)
{
    for (int i = 0; i < count; i++)
    {
        if (items[i].Equals(toRemove))
        {
            int removeIndex = i;
            for (int j = removeIndex; j < count - 1; j++)
            {
                items[j] = items[j + 1];
            }
            return true;
        }
    }
    return false;
}

Use a boolean variable and set it to true if an item is found, and continue your loop until you go through all elements, then return the boolean value. — Ryan Wilson
– Ryan Wilson, Commented Nov 9, 2018 at 15:30
That's awesome, didn't think of that. That did it, many thanks. — MBrewers
– MBrewers, Commented Nov 9, 2018 at 15:41

apomene · Accepted Answer · 2018-11-09 15:31:23Z

2

If you want to complete the loop, do not return. Instead hold the result on a var you should return at the end:

    public bool Remove(T toRemove)
    {
        bool result = false;
        for (int i = 0; i < count; i++)
        {
            if (items[i].Equals(toRemove))
            {
                int removeIndex = i;
                for (int j = removeIndex; j < count - 1; j++)
                {
                    items[j] = items[j + 1];
                }
                result = true;
            }
        }
        return result;
    }

answered Nov 9, 2018 at 15:31

apomene

14.4k10 gold badges51 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mureinik · Accepted Answer · 2018-11-09 15:36:58Z

1

Just save the result in a variable and return it after the loop is complete:

public bool Remove(T toRemove)
{
    bool result = false;
    for (int i = 0; i < count; i++)
    {
        if (items[i].Equals(toRemove))
        {
            int removeIndex = i;
            for (int j = removeIndex; j < count - 1; j++)
            {
                items[j] = items[j + 1];
            }
            result = true;
        }
    }
    return result;
}

edited Nov 9, 2018 at 15:36

answered Nov 9, 2018 at 15:32

Mureinik

316k54 gold badges399 silver badges405 bronze badges

2 Comments

Tân Over a year ago

I think you meant bool instead of boolean.

Mureinik Over a year ago

@TânNguyễn true 'dat. Momentary lapse of concentration, thanks for noticing.

Ryan Wilson · Accepted Answer · 2018-11-09 15:31:39Z

1

//Use a boolean variable and set it to true if an item is found, 
//and continue your loop until you go through all elements, then return the boolean value.  

public bool Remove(T toRemove)
{
        bool match= false; //boolean to track if any match is found
        for (int i = 0; i < count; i++)
        {
            if (items[i].Equals(toRemove))
            {
                int removeIndex = i;
                for (int j = removeIndex; j < count - 1; j++)
                {
                    items[j] = items[j + 1];
                }
                match= true;
            }
        }

        return match;
}

answered Nov 9, 2018 at 15:31

Ryan Wilson

10.9k3 gold badges23 silver badges46 bronze badges

Comments

Kevin · Accepted Answer · 2018-11-09 15:31:40Z

0

I think what you want to do is declare a bool called "result" and instantiate it to false. In the loop where you are returning true, set "result" to true. At the end, where you are returning false, return "result"

answered Nov 9, 2018 at 15:31

Kevin

7,34913 gold badges50 silver badges72 bronze badges

Collectives™ on Stack Overflow

C# List loop within a loop?

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related