Nodejs doesn't save hashed password to mysql db

Question

New to NodeJS, trying to write user registration by my own, but facing a trouble when app saves non-hashed password. Tried to check if password is hashed before saving and alert says it is. Here's my code:

var userData = {
        email: req.body.email,
        password: req.body.password
    }

        var user = userData;

        bcrypt.hash(user.password, 10, function(err, hash){
                if(err) console.log(err);
                user.password = hash;
                alert(user.password); //shows hashed password
            });

        //skipped connection code

        database.connection.query("insert into users set ?", user, function(err){ //saves non-hashed password
            if(err) console.log(err);
            console.log("successfull");

        });

P Ackerman · Accepted Answer · 2018-07-07 20:14:12Z

bcrypt.hash is asynchronous. You have what is essentially a race condition in your code.

    database.connection.query("insert into users set ?", user, function(err){ //saves non-hashed password
        if(err) console.log(err);
        console.log("successfull");

    });

When you pass user to this method, user.password has not yet been populated by the bcrypt.hash callback.

You'll need to put the query logic in the bcrypt callback if you stick with a callback oriented style, though most javascripters would likely use promises or async/await (which should be available natively in most recent releases of Node.js).

    bcrypt.hash(user.password, 10, function(err, hash){
            if(err) console.log(err);
            user.password = hash;
            alert(user.password); //shows hashed password

            //>>query logic should go here.
        });

Mike · Accepted Answer · 2018-07-07 20:16:43Z

Looks like you need to put the database query inside the callback. Try something like this:

    var userData = {
       email: req.body.email,
       password: req.body.password
    }

    var user = userData;

    bcrypt.hash(user.password, 10, function(err, hash){
         if(err) console.log(err);
         user.password = hash;
         database.connection.query("insert into users set ?", 
            user, function(err){ //saves non-hashed password
            if(err) console.log(err);
            console.log("successfull");
        });
    });

Node.js is asynchronous like that. That is why there are callback functions. You are inserting the user before you have hashed the password or those events happened at the same time. Basically, you have a race condition.

Collectives™ on Stack Overflow

Nodejs doesn't save hashed password to mysql db

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related