Replace strings with objects in nested arrays

Question

I have a large JS object which I feed to a factory. The original object contains strings in an array which are a parameter for the factory.

I would like to shorten the code to as short as possible and hopefully be functional.

What I have so far:

const myConfigObject = {
  label: 'something',
  children: [
    {
      id: 'one',
      style: 'some style',
      children: ['key1', 'key2']
    },
    {
      id: 'two',
      style: 'some other style',
      children: ['key3', 'key4']
    },
  ]
}

function DummyFactory (key) {
  return {
    id: key,
    data: 'generated stuff'
  };
}

// How to optimize this call?
myConfigObject.children.forEach(child => {
  child.children = child.children.map(subChild => DummyFactory(subChild))
});

console.log(myConfigObject);

What do you mean by "optimize"? If you must to visit each string, you can't reduce iterations number.. May be use webworkers to parallelize the work? — vp_arth
– vp_arth, Commented May 3, 2018 at 17:38
IMHO this is already pretty well optimized; if you're still looking for pointers, this should go on codereview.stackexchange.com — Máté Safranka
– Máté Safranka, Commented May 3, 2018 at 17:38

Bergi · Accepted Answer · 2018-05-03 17:39:57Z

2

There's not much to do here, but I would go for

function DummyFactory(key) {
  return {
    id: key,
    data: 'generated stuff'
  };
}
const myConfigObject = {
  label: 'something',
  children: [
    {
      id: 'one',
      style: 'some style',
      children: ['key1', 'key2'].map(DummyFactory)
    },
    {
      id: 'two',
      style: 'some other style',
      children: ['key3', 'key4'].map(DummyFactory)
    },
  ]
};

answered May 3, 2018 at 17:39

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vp_arth · Accepted Answer · 2018-05-03 17:44:51Z

1

Trying to shortening:

myConfigObject.children.forEach(
 child => child.children = child.children.map(DummyFactory));

answered May 3, 2018 at 17:44

vp_arth

15k4 gold badges43 silver badges72 bronze badges

Comments

Naga Sai A · Accepted Answer · 2018-05-03 18:01:05Z

To achieve expected use below option of even avoiding DummyFactory

myConfigObject.children.forEach(child => {
  child.children = child.children.map(subChild=> {
  return {
    "id":subChild,
    "data": 'generated stuff'
    }   
  })
});

code sample - https://codepen.io/nagasai/pen/VxWJYd?editors=1010

const myConfigObject = {
  label: 'something',
  children: [
    {
      id: 'one',
      style: 'some style',
      children: ['key1', 'key2']
    },
    {
      id: 'two',
      style: 'some other style',
      children: ['key3', 'key4']
    },
  ]
}


myConfigObject.children.forEach(child => {
  child.children = child.children.map(subChild=> {
  return {
    "id":subChild,
    "data": 'generated stuff'
    }   
  })
});

console.log(myConfigObject);

Collectives™ on Stack Overflow

Replace strings with objects in nested arrays

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related