0

I have an array with many nested arrays and objects. My code doesn't work and after looking at it over and over again, I don't understand why. Its hard to explain what I mean (sorry if my title question was also not very clear, but I didn't know how to explain what I mean, if I don't know whats wrong in my code), so I put my 2 questions insight my code as comments - I hope its understandable! Thanks a lot for any ideas.

var trips= [{
   "Air": {
        "OriginDestinationOptions": {
            "OriginDestinationOption": [{
                "Flight": [{
                    "DepartureAirport": {
                        "LocationCode": "JFK"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "SVO"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }, {
                    "DepartureAirport": {
                        "LocationCode": "SVO"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "TXL"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }

                },
                {
                    "DepartureAirport": {
                        "LocationCode": "TXL"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "LHR"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }

                }],
                "ElapsedTime": 915
            }, {
                "Flight": [{
                    "DepartureAirport": {
                        "LocationCode": "LHR"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "LAX"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }, {
                    "DepartureAirport": {
                        "LocationCode": "LAX"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "TXL"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                },
                 {
                    "DepartureAirport": {
                        "LocationCode": "TXL"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "LHR"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }

                }],
                "ElapsedTime": 1425
            }]
        },
        "DirectionInd": "Return"
    }
}, 
{
    "Air": {
        "OriginDestinationOptions": {
            "OriginDestinationOption": [{
                "Flight": [{
                    "DepartureAirport": {
                        "LocationCode": "JFK"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "SVO"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }, {
                    "DepartureAirport": {
                        "LocationCode": "SVO"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "LHR"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }],
                "ElapsedTime": 915
            }, {
                "Flight": [{
                    "DepartureAirport": {
                        "LocationCode": "LHR"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "SVO"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }, {
                    "DepartureAirport": {
                        "LocationCode": "SVO"
                    },
                    "ArrivalAirport": {
                        "LocationCode": "JFK"
                    },
                    "MarketingAirline": {
                        "Code": "SU"
                    }
                }],
                "ElapsedTime": 1125
            }]
        },
        "DirectionInd": "Return"
    }        
}];

My code:

var flightObjects = [];

     function getAirportNameToLocation(obj) {
         var allTrips = [];
         for (var i = 0; i < obj.length; i++) {                  

      allTrips.push(obj[i].Air.OriginDestinationOptions.OriginDestinationOption)
         }

         for (var i = 0; i < allTrips.length; i++) {

             var toDestinationFlightsTemp = [];
             var returnFlightsTemp = [];
             //first FlightsSegment object --> to destination flights
             var flightsToLoc = allTrips[i][0];

             //second FlightsSegment object --> return flights
             var returnFlights = allTrips[i][1];

             console.log(toDestinationFlightsTemp)

1.) when I console log 'toDestinationFlights'-I get an empty array, but 2 lines below when I push ALSO (same as I console log before) toDestinationFlights to my flightObjects object and return that object, Im actually not getting back an empty array, but values. I don't know why.

             console.log("test", toDestinationFlightsTemp)
             flightObjects.push({

2.) What was intended here: toDestinationFlights: toDestinationFlightsTemp.concat(returnFlights[0]) - I want the values from toDestinationFlightsTemp and the first value from returnFlightsTemp this doesnt work because again, somehow Im getting an empty array

                 toDestinationFlights: toDestinationFlightsTemp, //This for whatever reason works fine
                 returnFlights: returnFlightsTemp
             })

             flightsToLoc.Flight.forEach(function(flightTo, i) {
                 toDestinationFlightsTemp.push(flightTo.DepartureAirport.LocationCode);
             })

             returnFlights.Flight.forEach(function(flightTo, i) {
             returnFlightsTemp.push(flightTo.DepartureAirport.LocationCode)
             })
         }
         toDestinationFlightsARIVALTemp = toDestinationFlightsTemp.concat(returnFlightsTemp[0]);
     }
     getAirportNameToLocation(trips)

     flightObjects;
Improve this question
14
  • 2
    Make your code runnable and convert your notes into comments, it is quite hard to debug such amount of code inside the head Commented Oct 22, 2017 at 14:19
  • So what information are you exactly trying to extract from your dataset? getAirportNameToLocation tells me you want an array with all the 'DepartureAirport->LocationCode'? Commented Oct 22, 2017 at 14:23
  • 1
    I just tested your code, in my case both console logs give an empty array, which is not surprising since you explicitely create it empty for each i 4 lines above. Commented Oct 22, 2017 at 14:30
  • You are creating/setting toDestinationFlightsTemp and returnFlightsTemp inside a loop then attempt to use it for toDestinationFlightsARIVALTemp outside the loop; this is not safe Commented Oct 22, 2017 at 14:36
  • I have refactored your code to make it more functional, hopefully this will help you spot which piece of logic is not as you expect jsbin.com/zolixiqude/edit?js,console Commented Oct 22, 2017 at 14:45

2 Answers 2

Reset to default
2

Here's why you're seeing what looks like unexpected behavior:

First you define variable outside the function flightObjects. Then you make a loop loop that will run twice:

for (var i = 0; i < allTrips.length; i++)

Then inside that loop you initialize a variable:

var toDestinationFlightsTemp = [];

This gets redefined every time through the loop. You console.log it and it's still an empty array because you haven't touched it.

Next you push that empty array onto the global flightObjects:

flightObjects.push({
            toDestinationFlights: toDestinationFlightsTemp, //This for whatever reason works fine
            returnFlights: returnFlightsTemp
        })

This doesn't actually work fine — flightObjects.toDestinationFlights is now pointing to the same empty array as toDestinationFlightsTemp. The first time through the loop, both print empty arrays. But then, after you've console.loged it, you add elements to it:

 flightsToLoc.Flight.forEach(function(flightTo, i) {
            toDestinationFlightsTemp.push(flightTo.DepartureAirport.LocationCode);
        })

Since toDestinationFlightsTemp and flightObjects.toDestinationFlights point to the same array, both toDestinationFlightsTemp and flightObjects.toDestinationFlights have the element you pushed into the array.

Now you loop again. On this loop you redefine toDestinationFlightsTemp and point it to a new empty array. But flightObjects still points to the same array and has a reference to the elements you pushed the first time through your loop. So now when you get to the console.logs toDestinationFlightsTemp is empty, but flightObjects still has the elements you pushed the first time though the loop. So you see those when you console.log it.

I think what you were intending to do would happen if you moved this up before you try to push the values into flightObjects:

        flightsToLoc.Flight.forEach(function(flightTo, i) {
            toDestinationFlightsTemp.push(flightTo.DepartureAirport.LocationCode);
        })
Improve this answer
Sign up to request clarification or add additional context in comments.

1 Comment

Thank you so much for this clear answer!!! It makes sense and now since I moved up my forEach loops it works great :)
0

Your code works. Here is how to make an embedded code snippet on Stackoverflow :

var trips = [{
  "Air": {
    "OriginDestinationOptions": {
      "OriginDestinationOption": [{
        "Flight": [{
          "DepartureAirport": {
            "LocationCode": "JFK"
          },
          "ArrivalAirport": {
            "LocationCode": "SVO"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "SVO"
          },
          "ArrivalAirport": {
            "LocationCode": "TXL"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "TXL"
          },
          "ArrivalAirport": {
            "LocationCode": "LHR"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }],
        "ElapsedTime": 915
      }, {
        "Flight": [{
          "DepartureAirport": {
            "LocationCode": "LHR"
          },
          "ArrivalAirport": {
            "LocationCode": "LAX"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "LAX"
          },
          "ArrivalAirport": {
            "LocationCode": "TXL"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "TXL"
          },
          "ArrivalAirport": {
            "LocationCode": "LHR"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }],
        "ElapsedTime": 1425
      }]
    },
    "DirectionInd": "Return"
  }
}, {
  "Air": {
    "OriginDestinationOptions": {
      "OriginDestinationOption": [{
        "Flight": [{
          "DepartureAirport": {
            "LocationCode": "JFK"
          },
          "ArrivalAirport": {
            "LocationCode": "SVO"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "SVO"
          },
          "ArrivalAirport": {
            "LocationCode": "LHR"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }],
        "ElapsedTime": 915
      }, {
        "Flight": [{
          "DepartureAirport": {
            "LocationCode": "LHR"
          },
          "ArrivalAirport": {
            "LocationCode": "SVO"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }, {
          "DepartureAirport": {
            "LocationCode": "SVO"
          },
          "ArrivalAirport": {
            "LocationCode": "JFK"
          },
          "MarketingAirline": {
            "Code": "SU"
          }
        }],
        "ElapsedTime": 1125
      }]
    },
    "DirectionInd": "Return"
  }
}];

var codesForEachTrip = [];
for (let i = 0; i < trips.length; i++) {
  let trip = trips[i];
  let origDestOpts = trip.Air.OriginDestinationOptions;
  let origDestOpt = origDestOpts.OriginDestinationOption;
  let outwardJourney = origDestOpt[0].Flight;
  let inwardJourney = origDestOpt[1].Flight;
  let codesForThisTrip = {
    outwardJourney: [],
    inwardJourney: []
  };
  for (let i = 0; i < outwardJourney.length; i++) {
    let sub = outwardJourney[i];
    let code = sub.DepartureAirport.LocationCode;
    codesForThisTrip.outwardJourney.push(code);
  }
  for (let i = 0; i < inwardJourney.length; i++) {
    let sub = inwardJourney[i];
    let code = sub.DepartureAirport.LocationCode;
    codesForThisTrip.inwardJourney.push(code);
  }
  codesForEachTrip.push(codesForThisTrip);
}
console.log(codesForEachTrip);

Improve this answer

8 Comments

@javascripting When I press "Run code snippet" I don't see any error.
I copy pasted your code into real and it also throws me an error.
@javascripting Copy-paste is not so easy after all ? ;-)
haha copy paste is pretty simple but there is an error in your code and thats the problem: 'Unexpected identifier 'i''
It's probably the let i are you running a browser that doesn't speak es6?
|

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.