PHP foreach loop

Question

I need to transfer the values from a PHP array into a JavaScript array so that it can be used in my application, I have managed to get up to this:

var Descriptions = array(<?php 
                foreach ($tasks as $task) {
                $ID = $task['ID'];
                $description = $task['description'];

                echo $ID . "[" . $description . "]" . ",";  
                }

                ?>);

and it works fine except for one thing: I dont know how to tell PHP to not put a comma after the last array value. The extra comma is causing a syntax error so it breaks my code.

Thanks in advance for any ideas, RayQuang

Jacob Relkin · Accepted Answer · 2011-01-07 07:38:12Z

2

The quick and dirty way:

for($i = 0, $c = count($tasks); $i < $c; $i++) {
   $task = $tasks[$i];
   ...
   echo $ID . "[" . $description . "]" . (($i != $c-1) ? "," : ''); 
}

There are obviously other ways of accomplishing this, one way would be to build up a string and then use the trim() function:

$tasks_str = '';
foreach(...) {
   ...
   $tasks_str .= ...
}

echo trim($tasks_str, ',');

Or, (my favorite), you could build up an array and then use implode on it:

$tasks_array = array();
foreach(...) {
   ...
   $tasks_array[] = ...
}

echo implode(',', $tasks_array);

edited Jan 7, 2011 at 7:38

answered Jan 7, 2011 at 7:28

Jacob Relkin

163k34 gold badges351 silver badges321 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Stephen Over a year ago

As i said - this is dangerous, you need to make sure you escape certain characters in the $ID and $description variables before outputting them into a JavaScript block. json_encode already does this for you.

Stephen · Accepted Answer · 2011-01-07 07:32:40Z

1

don't try to build it manually, use json_encode

answered Jan 7, 2011 at 7:32

Stephen

19k4 gold badges35 silver badges33 bronze badges

1 Comment

Stephen Over a year ago

I can't understand why you would ever want to use any other method?

Oliver O'Neill · Accepted Answer · 2011-01-07 15:55:44Z

1

var Descriptions = <?=json_encode($tasks);?>;

answered Jan 7, 2011 at 15:55

Oliver O'Neill

1,2546 silver badges11 bronze badges

Comments

Jishnu A P · Accepted Answer · 2011-01-07 07:29:56Z

0

var DescriptionsString = <?php 
            foreach ($tasks as $task) {
            $ID = $task['ID'];
            $description = $task['description'];

            echo $ID . "[" . $description . "]" . ",";  
            }

            ?>;
var Descriptions = DescriptionsString.split(',');

answered Jan 7, 2011 at 7:29

Jishnu A P

14.4k8 gold badges42 silver badges52 bronze badges

Comments

Nik · Accepted Answer · 2011-01-07 07:32:02Z

0

try,

var Descriptions = array(<?php 
                $str = '';
                foreach ($tasks as $task) {
                $ID = $task['ID'];
                $description = $task['description'];

                $str .= $ID . "[" . $description . "]" . ",";  
                }
                 echo trim($str,',');      
                ?>);

answered Jan 7, 2011 at 7:32

Nik

4,0653 gold badges23 silver badges16 bronze badges

Comments

jensgram · Accepted Answer · 2011-01-07 07:33:39Z

0

Not one to miss out on a trend:

$out = array();
foreach ($tasks as $task) {
    $ID = $task['ID'];
    $description = $task['description'];

    $out[] = $ID . "[" . $description . "]";  
}
echo implode(',', $out);

Using implode().

answered Jan 7, 2011 at 7:33

jensgram

31.6k6 gold badges83 silver badges101 bronze badges

Collectives™ on Stack Overflow

PHP foreach loop

6 Answers 6

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related