TypeError: First argument must be a string or Buffer. Javascript

Question

var formData = {
  name: 'TestDeck',
  description: 'This is a test deck for my api',
  private: false,
  shareable: false,
  ttsLanguages: [],
  blacklistedSideIndices: [],
  blacklistedQuestionTypes: [],
  gradingModes: [],
  imageAttribution: 'https://www.logogarden.com/wp-content/uploads/lg-index/Example-Logo-6.jpg',
  imageFile: fs.readFile('retext.png', 'utf8')
}

function createDeck(connection) {
  request.post({
      url: '<url>',
      formData: formData,
      headers: {
        'Content-Type': 'multipart/form-data'
      },
      json: true
    }),
    function(err, resp, body) {

    }
}

I am getting the error: TypeError: First argument must be a string or Buffer.

I honestly have no idea why, need help.

fs.readFile is an asynchronous method, so imageFile most likely isn't what you think it is — adeneo
– adeneo, Commented Sep 9, 2017 at 19:59

Community · Accepted Answer · 2020-06-20 09:12:55Z

5

There are several problems in the code.

You get TypeError: First argument must be a string or Buffer because you are trying to send boolean value false in form data -- HTML form does not support boolean value. In HTML, checked checkbox will send its value, while unchecked checkbox won't.

To fix the issue, you can change false to 'FALSE'(string) and parse it in server side.
The use of fs.readFile('retext.png', 'utf8') is incorrect. To attach file in the form, the right way is: imageFile: fs.createReadStream('retext.png').
When formData: formData is used in request.post(...), the Content-Type of the HTTP request would be multipart/form-data automatically, you don't need to define Content-Type header again.

Moreover, it is incorrect to set json: true, which will make Content-Type as application/json. This conflict will make request module confused, and may cause problem in some JavaScript environment.
The callback function function(err, resp, body){...} should be part of request.post(...), maybe it is a typo.

In summary, the correct code would look like:

var formData = {
  name: 'TestDeck',
  description: 'This is a test deck for my api',
  private: 'FALSE',
  shareable: 'FALSE',
  ttsLanguages: [],
  blacklistedSideIndices: [],
  blacklistedQuestionTypes: [],
  gradingModes: [],
  imageAttribution: 'https://www.logogarden.com/wp-content/uploads/lg-index/Example-Logo-6.jpg',
  imageFile: fs.createReadStream('retext.png')
}

function createDeck(connection) {
  request.post({
    url: '<url>',
    formData: formData
  }, function(err, resp, body) {

  })
}

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Sep 10, 2017 at 10:27

shaochuancs

16.4k3 gold badges63 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Spearmint Over a year ago

Thank you very much, just what I needed

Sagar Chamling Over a year ago

you saved my day. I was appending boolean value in it. Thanks.

Collectives™ on Stack Overflow

TypeError: First argument must be a string or Buffer. Javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related