docker run bash script cannot exit

Question

In my CI system，jenkins execute shell script to build ... The script like this:

docker run -d --rm -v /code-path:/tmp docker-iamge-name sh -c " \
    cd /tmp ;\
    mkdir build ;\
    cd build ;\
    cmake ../ ;\
    make ;\
    ./unit-test-execute-file1 ;\
    ...
"

But when there are errors in code file, make command exits, and then next command(./unit-test-execute-file1) is executed. Since make failed, so unit-test-execute-file is not generated, and next command also fails... In the end, script exit with code 0, and Jenkins shows build is successful..

Can someone help? Thanks a lot!

Ayushya · Accepted Answer · 2017-08-16 06:57:11Z

1

You should use set -e as the first line in the bash script if you want that script should exit at any point the script fails.

Your run statement would look like:

docker run -d --rm -v /code-path:/tmp docker-iamge-name sh -c " \
    set -e ;\
    cd /tmp ;\
    mkdir build ;\
    cd build ;\
    cmake ../ ;\
    make ;\
    ./unit-test-execute-file1 ;\
    ...
"

answered Aug 16, 2017 at 6:57

Ayushya

10.5k6 gold badges43 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

chepner · Accepted Answer · 2017-08-16 16:46:53Z

1

Rather than rely on set -e (which really is not reliable, at least not without fully understanding all the exceptions that don't exit the shel), be explicit about which commands to run. In this case, you can simply chain the commands together with &&, so that each command only runs if the previous command succeeds. The exit status of the chain is the exit status of the last command to run (e.g., if cd build fails, its exit status is the exit status of sh -c).

docker run -d --rm -v /code-path:/tmp docker-iamge-name sh -c "
  cd /tmp &&
  mkdir build &&
  cd build &&
  cmake ../ &&
  make &&
  ./unit-test-execute-file1 &&
  ...
"

answered Aug 16, 2017 at 16:46

chepner

538k77 gold badges594 silver badges746 bronze badges

Collectives™ on Stack Overflow

docker run bash script cannot exit

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related