Unable to properly fill form with array values using loop

Question

Please I need help fixing this. I am trying to fill a form using values of array but its messing up the form.

I want to display the af_rating in the input fields

<?php
    $af_skill = array(12, 9, 6, 3, 4, 5, 7);
    foreach ($af_skill as $k => $row_af):
    ?>
    <div class="form-group">
        <div class="col-sm-5">
            <?php
            $af_skill_rating = array(1, 2, 5, 4, 3, 2, 4);
            foreach ($af_skill_rating as $k2 => $af_rating):
                ?>
                <input type="number" class="form-control" name="af_rating-<?= $row_af[$k]; ?>" value="<?php echo $af_rating[$k2]; ?>" max="5" min="1" required> <br>
            <?php endforeach; ?>
        </div>
    </div>
<?php endforeach; ?>

it should look like this below image

$af_rating is a number, there's no [$k2] index for it.

u_mulder
– u_mulder

2017-06-29 14:09:58 +00:00
Commented Jun 29, 2017 at 14:09 — u_mulder
– u_mulder, Commented Jun 29, 2017 at 14:09
Just remove the index from <?php echo $af_rating[$k2]; ?>

Murad Hasan
– Murad Hasan

2017-06-29 14:23:31 +00:00
Commented Jun 29, 2017 at 14:23 — Murad Hasan
– Murad Hasan, Commented Jun 29, 2017 at 14:23
Yes, I have removed the index, but foreach loop is now 7*7

Mysterio4
– Mysterio4

2017-06-29 14:27:24 +00:00
Commented Jun 29, 2017 at 14:27 — Mysterio4
– Mysterio4, Commented Jun 29, 2017 at 14:27

Edison Biba · Accepted Answer · 2017-06-29 14:29:17Z

1

You are using a simple array as PHP Associative Arrays.

You could use your code if you had something like this

$age = array("Peter"=>"35", "Ben"=>"37", "Joe"=>"43");
foreach($age as $key => $value){
   //first time in this loop $key = Peter 
   //and $value = "35"
}

I changed that in your code.

<?php
$af_skill = array("12" => "1", "9" => "2", "6" => "5", "3" => "4", "4" => "3", "5" => "2", "7" => "4");

foreach ($af_skill as $key => $value): ?>
    <div class="form-group">


        <div class="col-sm-5">


                <input type="number" class="form-control" name="af_rating-<?php echo $key ?>"
                       value="<?php echo $value; ?>" max="5" min="1" required> <br>

        </div>


    </div>

<?php endforeach; ?>

Also check your foreach because you are using foreach loop inside each other so that will produce 7*7 inputs

edited Jun 29, 2017 at 14:29

answered Jun 29, 2017 at 14:17

Edison Biba

4,4833 gold badges20 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mysterio4 Over a year ago

I have used your code, but I think theres a conflict with the foreach loops. I just want for each af_skill, there should be an af_rating

Mysterio4 Over a year ago

Yes the foreach loops is 7*7 time and I need it just once

Edison Biba Over a year ago

I replaced your arrays with one Associative array so you can try it now.

RAUSHAN KUMAR · Accepted Answer · 2017-06-29 14:11:41Z

1

you have error in this line, you are using values as an array. So change this line

<input type="number" class="form-control" name="af_rating-<?= $row_af[$k]; ?>" value="<?php echo $af_rating[$k2]; ?>" max="5" min="1" required/>

with

<input type="number" class="form-control" name="af_rating-<?= $row_af[$k]; ?>" value="<?php echo $af_rating; ?>" max="5" min="1" required/>

answered Jun 29, 2017 at 14:11

RAUSHAN KUMAR

6,0345 gold badges37 silver badges70 bronze badges

3 Comments

Mysterio4 Over a year ago

I did that, the numbers have now displayed but it created 42 inputs instead of just 7

RAUSHAN KUMAR Over a year ago

you have two for loops, for each outer loop the inner loop is repeating 7 times

Mysterio4 Over a year ago

Yes exactly, thats the problem I am facing. I want it resolved in the sense that for each af_skill, there should be a af_rating in the input field

Dano · Accepted Answer · 2017-06-29 14:33:51Z

1

You don't need to loop twice. With your setup, the keys from one array will match the keys from the second (af_skill[0] will correspond with af_skill_rating[0]). I submit the following code:

<?php
    $af_skill = array(12, 9, 6, 3, 4, 5, 7);
    $af_skill_rating = array(1, 2, 5, 4, 3, 2, 4);
    foreach ($af_skill as $k => $row_af):
?>
<div class="form-group">
    <div class="col-sm-5">
            <input type="number" class="form-control" name="af_rating-<?= $row_af; ?>" value="<?php echo $af_skill_rating[$k]; ?>" max="5" min="1" required> <br>
    </div>
</div>
<?php endforeach; ?>

answered Jun 29, 2017 at 14:33

Dano

1699 bronze badges

Collectives™ on Stack Overflow

Unable to properly fill form with array values using loop

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related