Python: Append JSON objects to nested list

Question

I'm trying to iterate through a list of IP addresses, and extracting the JSON data from my url, and trying to put that JSON data into a nested list.

It seems as if my code is overwriting my list over and over, and will only show one JSON object, instead of the many I have specified.

Here's my code:

for x in range(0, 10):
    try:
        url = 'http://' + ip_addr[x][0] + ':8080/system/ids/'
        response = urlopen(url)
        json_obj = json.load(response)
    except:
        continue

    camera_details = [[i['name'], i['serial']] for i in json_obj['cameras']]

for x in camera_details:
    #This only prints one object, and not 10.
    print x

How can I append my JSON objects into a list, and then extract the 'name' and 'serial' values into a nested list?

Please properly indent your code... Did I fixed it correctly? — willeM_ Van Onsem
– willeM_ Van Onsem, Commented Jun 15, 2017 at 0:51

Mr. A · Accepted Answer · 2017-06-15 01:05:26Z

1

try this

camera_details = []
for x in range(0, 10):
    try:
        url = 'http://' + ip_addr[x][0] + ':8080/system/ids/'
        response = urlopen(url)
        json_obj = json.load(response)
    except:
        continue

    camera_details.extend([[i['name'], i['serial']] for i in json_obj['cameras']])

for x in camera_details:
    print x

in your code you where only getting the last requests data

Best would be using append and avoiding list comprehension

camera_details = []
for x in range(0, 10):
    try:
        url = 'http://' + ip_addr[x][0] + ':8080/system/ids/'
        response = urlopen(url)
        json_obj = json.load(response)
    except:
        continue
    for i in json_obj['cameras']:
        camera_details.append([i['name'], i['serial']])

for x in camera_details:
    print x

edited Jun 15, 2017 at 1:05

answered Jun 15, 2017 at 0:57

Mr. A

1,23118 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

juiceb0xk Over a year ago

Thank you very much. This has seemed to work for me and looking at how it works from this side gives a definite insight into how I should have been interpreting my lists. Awesome, thank you so much!

Software2 · Accepted Answer · 2017-06-15 00:58:46Z

1

Try breaking up your code into smaller, easier to digest parts. This will help you to diagnose what's going on.

camera_details = []
for obj in json_obj['cameras']:
    if 'name' in obj and 'serial' in obj:
        camera_details.append([obj['name'], obj['serial']])

answered Jun 15, 2017 at 0:58

Software2

2,7981 gold badge24 silver badges30 bronze badges

Collectives™ on Stack Overflow

Python: Append JSON objects to nested list

2 Answers 2

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related