Angular: Call method using string value for name

Question

So I have Googled this quite allot today, and I'm afraid the answers I got, did not satisfy the problem I'm facing. I'm trying to call a method within a controller (controller as syntax) by only using a string value.

I tried window['someFunctionName'](); as well as this['someFunctionName'](); and vm['someFunctionName'](), but non of them seems to work. I'm guessing it's because the function I'm calling is not in a global space, but rather local to the controller - example:

/* @ngInject */
function dashboardController(logger, _, moment) {
    var vm = this;

    vm.foo = foo

    function getSomeData() {
        // do something....
    }

    function foo() {
        window['getSomeData']();
        this['getSomeData']();
        vm['getSomeData']();
    }

}

It feels so trivial ... I could do this soooooo easily in C#, but struggling with something that feels so silly!

Any advice? Thanks!

Deblaton Jean-Philippe · Accepted Answer · 2017-05-22 15:20:10Z

1

If you don't want your function to be accessible from your template, you can still create a kind of container for your functions :

var functionContainer = {};
functionContainer.getSomeData = function() {
    // Do some stuff
}

Going further, your "get data" function should be in a service that you will inject into your controller.

angular.module('myApp').factory('getDataService', function(){
    return {
         'getSomeData': getSomeData,
         'getOtherData': getOtherData
    };


    function getSomeData() {
       // do some stuff
    }

    function getOtherData() {
       // do other stuff
    }
});

/* @ngInject */
function dashboardController(logger, _, moment, getDataService) {
    var vm = this;

    vm.foo = function () {
        getDataService['getSomeData']();
    };

}

edited May 22, 2017 at 15:20

answered May 22, 2017 at 14:28

Deblaton Jean-Philippe

11.4k4 gold badges53 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Richard Bailey Over a year ago

Sure, but this will make the function public - this is what I ended up doing, but it feels like cheating

Deblaton Jean-Philippe Over a year ago

That's the way angular ^1.5 works with the 'controller as' syntax. If you don't want it to be "public", you can use the $scope way, but I wouldn't recomment it.

Richard Bailey Over a year ago

I totally agree

Deblaton Jean-Philippe Over a year ago

maybe I misunderstood your question. What if you bind the function to a new object? var functionContainer = {}; functionContainer.getSomeData = function(){};

Deblaton Jean-Philippe Over a year ago

@RichardBailey answer updated, I hope it'll suit you

|

Andrei Kropotin · Accepted Answer · 2017-05-22 14:30:58Z

0

Can you try

/* @ngInject */
function dashboardController(logger, _, moment) {
    var vm = this;

    vm.foo = foo

    vm.getSomeData = function() {
        // do something....
    }

    function foo() {
        vm.getSomeData();
    }

}

answered May 22, 2017 at 14:30

Andrei Kropotin

2934 silver badges9 bronze badges

1 Comment

Richard Bailey Over a year ago

Thanks for the response! I see - almost like a get;set; - in this case only a get;

anoop · Accepted Answer · 2017-05-22 14:33:54Z

0

Just simply call getSomeData(); from foo. Like:

   function foo() {
       getSomeData();
    }

See this fiddle

answered May 22, 2017 at 14:33

anoop

3,8222 gold badges18 silver badges28 bronze badges

3 Comments

Richard Bailey Over a year ago

Hmmm - sure that is pretty easy, but not my question. I'm trying to call a method using the string value and not the actual ref to the function.

anoop Over a year ago

okay, then you have to assign it to vm, like : vm.getSomeData = function() {//....); }, and then can call it vm['getSomeData']();

Richard Bailey Over a year ago

Thanks for the response!

Collectives™ on Stack Overflow

Angular: Call method using string value for name

3 Answers 3

6 Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

6 Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related