Convert String to DateTime C# ASP.NET

Question

I am having an issue trying to convert a String to DateTime. I have tried a few things but I keep getting errors thrown up when trying to update the record.

string consentGiven = ConsentGivenDate.Text;
DateTime date1 = Convert.ToDateTime(consentGiven);
cmd.Parameters.Add(new SqlParameter("@ConsentGivenDate", date1));

if ((ConsentGivenDate.Text == "dd/mm/yyyy"))
    cmd.Parameters.Add("@ConsentGivenDate", SqlDbType.DateTime).Value = DBNull.Value;
else
    cmd.Parameters.Add("@ConsentGivenDate", SqlDbType.DateTime).Value = ConsentGivenDate.Text;

I have tried to add a bit of formatting in so the Date is in British format 'dd/mm/yyyy' but still can't convert it over.

What have I done wrong?

I am a real coding novice so apologies if it is something stupid....

If the column in the database is a DateTime,why do you want to insert a string? Just cmd.Parameters.Add("@ConsentGivenDate", SqlDbType.DateTime).Value = date1 — Pikoh
– Pikoh, Commented Apr 17, 2017 at 13:36

Graham · Accepted Answer · 2017-09-22 02:09:31Z

0

Always use instances of the correct type in your Sql Parameters. When a parameter corresponds with a Date or DateTime in your database schema then the corresponding .net type should be DateTime and not string.

object sqlValue = DBNull.Value;
DateTime dateConsentGiven;

if(DateTime.TryParseExact(ConsentGivenDate.Text, "dd/mm/yyyy", CultureInfo.InvariantCulture, DateTimeStyles.None, out dateConsentGiven))
    sqlValue = dateConsentGiven;
cmd.Parameters.Add("@ConsentGivenDate", SqlDbType.DateTime).Value = sqlValue;

Also note that you are adding the same parameter multiple times in your original code in your question, Sql Server uses named parameters which means the parameter name is unique.

edited Sep 22, 2017 at 2:09

Graham

7,86020 gold badges67 silver badges92 bronze badges

answered Apr 17, 2017 at 13:41

Igor

62.5k10 gold badges111 silver badges181 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

CDspace · Accepted Answer · 2017-04-17 17:33:12Z

-1

DateTime dt = DateTime dt=DateTime.ParseExact("ConsentGivenDate.Text", "dd/MM/yyyy", CultureInfo.InvariantCulture);
cmd.Parameters.Add(new SqlParameter("@ConsentGivenDate", dt));
cmd.Parameters.Add("@ConsentGivenDate", SqlDbType.DateTime).Value = DBNull.Value;

edited Apr 17, 2017 at 17:33

CDspace

2,69919 gold badges32 silver badges39 bronze badges

answered Apr 17, 2017 at 13:51

user7415073

3004 silver badges25 bronze badges

Collectives™ on Stack Overflow

Convert String to DateTime C# ASP.NET

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related