AngularJS and $http get JSON - data is not defined

Question

Hi I am trying to retrieve some data from webservice using AngularJS $http get.

I have the following code snippet:

In the servicesjs:

     .factory('BoothDesignatedCoordsService', ['$http', function ($http) {

var factory = {};

factory.getBoothDesignatedCoords = function (strBoothName, intFloorPlanID) {


 var sendToWS;
 var boothDesignatedCoords

    var JSONObj = {
        BoothName: strBoothName,
        FloorPlanID: intFloorPlanID
    };
    sendToWS = JSON.stringify(JSONObj)

    var urlBase = 'http://localhost:4951/wsIPS.asmx/fnGetBoothDesignatedCoords?objJSONRequest=' + sendToWS;
        return $http.get(urlBase) 
}
return factory;

}])

In the controllerjs:

 var boothDesignatedCoords = BoothDesignatedCoordsService.getBoothDesignatedCoords(strListShortListedBooth[i], 3).success(function (response, data, status) {
        console.log("successfully send booth name and floor plan id to ws");
        console.log("data " + data + " , status : " + status);
        console.log("data " + data);
        boothDesignatedCoords = data;

   for (var c = 0; c < boothDesignatedCoords.length; c += 2) {

   }

The $http get is successful as I am able to print "successfully send booth name and floor plan id to ws" in the browser console log. When I tried to print console.log("data " + data), it gives me some values of an integer array. That is exactly what I want. But in the controller I tried to assign data to the variable boothDesignatedCoords, the program does not run the for loop. Am I missing some code?

EDIT: I tried to trace the code ( trace the variable called "data" in the controllerjs) and it says "data is not defined"

I tried to trace the code ( trace the variable called "data" in the controllerjs) and it says "data is not defined" — Hardyanto Putra Antony. K
– Hardyanto Putra Antony. K, Commented Feb 8, 2017 at 3:52
Try using console log this way: console.log("data ", data); that will give you the data not just [Object] — slackmart
– slackmart, Commented Feb 8, 2017 at 3:53
For the .success() function your first variable is the data returned by the $http.get function, so the second variable would not be what you're looking for I think. — forrestmid
– forrestmid, Commented Feb 8, 2017 at 3:56

Phil · Accepted Answer · 2017-02-08 04:43:35Z

1

You appear to be confused about the methods available on the $http promise and their arguments. Try this

BoothDesignatedCoordsService.getBoothDesignatedCoords(strListShortListedBooth[i], 3)
.then(function(response) {
  var data = response.data
  var status = response.status

  console.log('data', data) // note, no string concatenation
  // and so on...
})

FYI, the success and error methods have been deprecated for some time and removed from v1.6.0 onwards. Don't use them.

I also highly recommend passing query parameters via the params config object

var urlBase = 'http://localhost:4951/wsIPS.asmx/fnGetBoothDesignatedCoords'
return $http.get(urlBase, {
  params: { objJSONRequest: sendToWS }
})

This will ensure the key and value are correctly encoded.

edited Feb 8, 2017 at 4:43

answered Feb 8, 2017 at 4:21

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Hardyanto Putra Antony. K Over a year ago

I tried to do this : console.log(data ) and it says [object Object]. What should I do to get the actual data?

Phil Over a year ago

@Antoni if you do console.log("data " + data), that will convert data to a string (hence the [Object object]). Instead, use console.log('data', data)

Hardyanto Putra Antony. K Over a year ago

I mean i tried this console.log("boothDesignatedCoords.length " + boothDesignatedCoords.length); out the then function, it says boothDesignatedCoords.length is 0. The for loop is outside of the then function.

Phil Over a year ago

@Antoni anything outside the then function will run before anything inside it. See stackoverflow.com/questions/14220321/…

Collectives™ on Stack Overflow

AngularJS and $http get JSON - data is not defined

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related