Button onClick does not working in reactjs

Question

I'm new to reactjs. I called this libraries in head tag:

    <script src="react/build/react.js"></script>
<script src="react/build/react-dom.js"></script>
<script src="https://unpkg.com/[email protected]/browser.min.js"></script>

<script src="https://cdn.socket.io/socket.io-1.4.5.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.0.1/react.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.0.1/react-dom.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/15.8.23/browser.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/2.2.2/jquery.min.js"></script>

<script src="chat-component.js" type="text/babel"></script>

and this is my react code:

var ChatApp = React.createClass({
  getInitialState: function () {
    return {
        messages: [],
        socket: window.io('http://localhost:3000')
    }
},
componentDidMount: function () {
  var self = this;
    this.state.socket.on("receive-message", function (msg) {
        console.log(msg);
        self.setState({messages: self.state.messages.push(msg)})
    });
},
render: function () {

    return (

        <div>
            <input id="message" type="text"/>
            <button type="button"  onClick={this.submitMessage} id="demo" value="send">send</button>
        </div>
    )
},
submitMessage: function () {

    var message = $('#message').value;
    // this.socket.emit("new-message", message);
     console.log(message);    
},

});

ReactDOM.render(
<ChatApp />,
document.getElementById("chat")
);

Why Button onClick does not working in my code? also in inspector, onClick does not exist :

<button type="button" id="demo" value="send">send</button>

I know my question is repeated but I really don't find its solution.

In this scenario, I'd suggest not using jQuery only because you can achieve what you want without it. You can add an onChange to your input so that you can update the state as the user types. Once the button is clicked, you can then simply just reference the value in your state. Here's the classical example from the reactjs docs: codepen.io/ericnakagawa/pen/QKkJva?editors=0010 — John F.
– John F., Commented Oct 23, 2016 at 12:19

Pranesh Ravi · Accepted Answer · 2016-10-23 12:45:17Z

1

Place the submitMessage function above render.

When render executes, this.submitMessage should be defined. In your code, it is defined only after render. So, It won't be called. And use val() to get the value from the textbox using jQuery

var ChatApp = React.createClass({
  getInitialState: function () {
    return {
        messages: [],
    }
  },
  submitMessage: function () {

    var message = $('#message').val();
    // this.socket.emit("new-message", message);
     console.log(message);    
  },
  render: function () {

      return (

          <div>
              <input id="message" type="text"/>
              <button type="button"  onClick={this.submitMessage} id="demo" value="send">send</button>
          </div>
      )
  }
});

ReactDOM.render(
<ChatApp />,
document.getElementById("chat")
);

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/15.1.0/react-dom.min.js"></script>
<div id="chat"></div>

edited Oct 23, 2016 at 12:45

answered Oct 23, 2016 at 12:17

Pranesh Ravi

19.2k10 gold badges51 silver badges70 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ParisaN Over a year ago

before, submitMessage() was render() before. I tested many ways. ):

Pranesh Ravi Over a year ago

@Digipng Updated the answer! Checknow!

Joseph Oliver · Accepted Answer · 2016-10-23 11:04:29Z

1

There are two problems that are preventing your code from working as you want:

i. I believe the methods should go inside the first argument to React.createClass. Try var ChatApp = React.createClass({ componentDidMount: function () { ... }, ...

instead.

ii. $('#message') will return as array of jquery elements that match your selection. To see this, console.log(message), instead of console.log(message.value). There are two basic ways to solve this: either extract the first element from the array then inspect it's value, or use the .val() method on the selected jQuery object, which will return the value of the first element in the set of matched elements.

See this plunkr for working example

edited Oct 23, 2016 at 11:04

answered Oct 23, 2016 at 10:59

Joseph Oliver

212 bronze badges

Collectives™ on Stack Overflow

Button onClick does not working in reactjs

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related