PHP json_encode with array only returns first element?

Question

I'm attempting to encode some values in JSON, so I can use them within other applications and also create a web API ~~for them.~~ to access them. I have this SQL method to grab data from my database:

function getAllMessages() {
    return getConnection()->query("SELECT * FROM allMessages ORDER BY programTimestamp DESC");
}

and I have this method to convert the data retrieved in JSON:

while( $row = getAllMessages()->fetch_assoc()) {
        $json[] = $row;
    }
    echo json_encode( $json );

I've also tried this:

echo json_encode(getAllMessages()->fetch_assoc());

and I only get the first element/value returned from the SQL query.

I dont see anything wrong.Are you sure you have more than 1 value in the db? — Mihai
– Mihai, Commented Apr 17, 2016 at 16:40
@Mihai yup, there are other values within the database. They appear on the website itself, just not when I use json_encode. — Jordan Osterberg
– Jordan Osterberg, Commented Apr 17, 2016 at 16:41
In your while loop if you do echo $row[someColumn]; do you get the expected results? — Mihai
– Mihai, Commented Apr 17, 2016 at 16:42
@Mihai, odd, it displays the same message over and over again. — Jordan Osterberg
– Jordan Osterberg, Commented Apr 17, 2016 at 16:44
@Mihai, seems like I solved the problem. Apparently directly using while ($row = getAllMessages) doesn't work — Jordan Osterberg
– Jordan Osterberg, Commented Apr 17, 2016 at 16:45

fusion3k · Accepted Answer · 2016-04-17 17:04:51Z

1

This code:

while( $row = getAllMessages()->fetch_assoc() ) {

produce an infinite loop: at each iteration, you call getAllMessages() and fetch first row, so while never ends unless that you have no result or boolean (False) result.

Change it in this way:

$rows = getAllMessages();
while( $row = $rows->fetch_assoc() )
{
    ...
}

answered Apr 17, 2016 at 17:04

fusion3k

11.7k4 gold badges27 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP json_encode with array only returns first element?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related