angularjs foreach loop issue

Question

I'm new to AngularJS and I'd like to build an object with data from a json file.

This is my json file:

[
  {"id": 1, "name": "user1", "select": false },
  {"id": 2, "name": "user2", "select": false },
  {"id": 3, "name": "user3", "select": false },
  {"id": 4, "name": "user4", "select": false },
  {"id": 5, "name": "user5", "select": false }
]

And now I want to use foreach loop to check which user has got select == true and push this username to new array. So here is my first Try:

'use strict';

angular.module('apiOmat', [])


  .controller('UsersCtrl', function($scope, $http){
    $http.get('users.json').then(function(usersResponse) {
      $scope.users = usersResponse.data;
    });


$scope.submit = function(message,title){

var tempArr = [];
angular.forEach($scope.users.name, function(value,key){
 tempArr.push(value);
});

console.log(tempArr);

    $scope.messagebody = '{ "title" = "' + title + '", "message" = "' + message  + '"}'; 
}

 });

I also tried this:

  $scope.submit = function(message,title){

    var tempArr = [];
    angular.forEach($scope.users, function(value,key){
     tempArr.push( { key :  value } );
    });

    console.log(tempArr);

The Console logs the 5 object, but without any value. Just 1: Object 2: Object 3: Object ...

I know that the query for true or false is missing. But I want to fix this step before adding a query.

Try this angular.forEach($scope.users,function(user){tempArr.push( user)}). — Stepan Kasyanenko
– Stepan Kasyanenko, Commented Mar 3, 2016 at 13:21
Thanks Thanks Thanks! It worked almost. I just used tempArr.push( username) to get the names of my user. — Paili
– Paili, Commented Mar 3, 2016 at 13:25

Ashish Bairagi · Accepted Answer · 2016-03-03 13:41:50Z

3

For this:

And now I want to use a foreach-loop to check which user has got select == true and push this username to my new array

$scope.submit = function(message,title){
   var tempArr = [];
   angular.forEach($scope.users, function(item){
     if( item.select == true){
       tempArr.push(item);
     }
   });

Another simple & better solution is to use filter instead.

$scope.submit = function(message,title){
    var tempArr = ($scope.users).filter(function(d){
         return (d.select == true);
    });
 });

console.log(tempArr)

edited Mar 3, 2016 at 13:41

answered Mar 3, 2016 at 13:29

Ashish Bairagi

3822 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Paili Over a year ago

Thank you very very much :)

Ashish Bairagi Over a year ago

try second one it is more better :)

Hadi · Accepted Answer · 2016-03-03 13:25:37Z

1

try this

   $scope.submit = function(message,title){
   var tempArr = [];
   angular.forEach($scope.users, function(user){
   tempArr.push( {"name":user.name} );
   });

answered Mar 3, 2016 at 13:25

Hadi

17.3k4 gold badges41 silver badges63 bronze badges

Comments

Boris Parnikel · Accepted Answer · 2016-03-03 13:40:36Z

1

Try this one

var tempArr = [];
angular.forEach($scope.users, function(user){
    user.select && tempArr.push(user.name);
});

console.dir(tempArr);

edited Mar 3, 2016 at 13:40

answered Mar 3, 2016 at 13:28

Boris Parnikel

8631 gold badge7 silver badges15 bronze badges

5 Comments

Boris Parnikel Over a year ago

Maybe it is because all of your users have "select" = false?? It works fine.jsfiddle.net/qp9qapgm

Paili Over a year ago

I copied not everything. My fault, sorry :D

Paili Over a year ago

Could you explain me something? I don't get that "user.select && tempArr.push(user.name);" Is that a short form for "if( item.select == true){ tempArr.push(item);"?

Boris Parnikel Over a year ago

@Paili Yes. Javascript uses lazy evaluation of logic expressions. In my case, it firstly checks that user.select is true (or another value that converts to true, see js doc). If it is, then js goes to second expression and evaluates it. Otherwise second expression is skipped, because all result will anyway equal to true and it is unnecessary to resolve all other stuff after 'false'.

Paili Over a year ago

Thanks a lot :) @Boris Parnikel

Nitu Bansal · Accepted Answer · 2016-03-03 14:07:28Z

1

try below

$scope.submit = function(message,title){

var tempArr = [];
angular.forEach($scope.users, function(i,j){

if(i.select == true)
{
 tempArr.push( i.name );
  }
});

console.log(tempArr);

edited Mar 3, 2016 at 14:07

answered Mar 3, 2016 at 13:22

Nitu Bansal

3,8563 gold badges20 silver badges24 bronze badges

1 Comment

Ashish Bairagi Over a year ago

This solution is not checking for select == true, I guess that is the main purpose you are iterating on the array.

Zeeshan Hassan Memon · Accepted Answer · 2016-03-03 13:30:56Z

0

Keep it simple:

$scope.submit = function(message, title){
   var tempArr = [];
   angular.forEach($scope.users, function(user){
    if( user.select == true) //filter select:true only
      tempArr.push( {"name_as_key":user.name} ); //name_as_key can be replaced if intended to
   });

answered Mar 3, 2016 at 13:30

Zeeshan Hassan Memon

8,3654 gold badges47 silver badges60 bronze badges

Collectives™ on Stack Overflow

angularjs foreach loop issue

5 Answers 5

2 Comments

Comments

5 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

5 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related