Trouble inserting array elements into database table

Question

I'm having pretty simple bug but I just can't figure out why it happens.I have this array:

Array
(
    [1] => Array
        (
            [A] => Joakim
            [B] => Dzafic
            [C] => [email protected]
        )

    [2] => Array
        (
            [A] => Jevren
            [B] => Jevrej
            [C] => [email protected]
        )

)

And I'm trying to insert it into my MySQL database table like so:

 foreach($sheetData as $rec){
    $result=$mysqli->query("INSERT INTO `test`(`name`,`surname`,`email`) VALUES
                (
                ".$rec['A'].",
                ".$rec['B'].",
                ".$rec['C']."
                );");
                if(!$result){
                    var_dump($result);
                    die("Something's wrong with query!");
                }else{
                    echo 'Inserted!';
                }

            }

But it says: Something's wrong with query! and when I do var_dump($result); it says: bool(false) Please help me to debug this part of code because I'm pretty stuck with it.

change foreach($sheetData as $rec){ to foreach($sheetData as $key => $rec) { — jitendrapurohit
– jitendrapurohit, Commented Feb 23, 2016 at 9:14

Chetan Ameta · Accepted Answer · 2016-02-23 09:14:23Z

1

you forgot to add single quote ' values variable should be enclosed by ' if it contains string:

$result=$mysqli->query("INSERT INTO `test`(`name`,`surname`,`email`) VALUES
                (
                '".$rec['A']."',
                '".$rec['B']."',
                '".$rec['C']."'
                )");

answered Feb 23, 2016 at 9:14

Chetan Ameta

7,8943 gold badges34 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ravi Hirani · Accepted Answer · 2016-02-23 09:16:31Z

0

You should use $mysqli->error to check query error.

Write your code as below:-

foreach($sheetData as $rec){
    $result=$mysqli->query("INSERT INTO `test`(`name`,`surname`,`email`) VALUES
                (
                '{$rec['A']}',
                '{$rec['B']}',
                '{$rec['C']}',
                )");  // typo error here
                if(!$result){
                    printf("Errormessage: %s\n", $mysqli->error); // check error
                    var_dump($result);
                    die("Something's wrong with query!");
                }else{
                    echo 'Inserted!';
                }

}

Hope it will help you :)

answered Feb 23, 2016 at 9:16

Ravi Hirani

6,5341 gold badge31 silver badges43 bronze badges

Comments

user2766477 · Accepted Answer · 2016-02-23 09:22:03Z

0

A little hint for the future, when you have such problems: var_dump($my_query)

Then you see where the syntax error is or what is going wrong there anyway. :-)

Don't forget to escape the value strings.

answered Feb 23, 2016 at 9:22

user2766477

766 bronze badges

Collectives™ on Stack Overflow

Trouble inserting array elements into database table

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related