Using a variable in jquery selector

Question

I want to change the src of an image file. Tried the below using with the variable, but it actually doesnt change it. Where did I made a mistake on using variable ?

jquery

var p2begen = "416";
$("[id=i'" + p2begen + "']").attr("src", "check.png");

html

<img src="nocheck.png" id="i416" \>

you are forgetting the # in $("[id=#i'" + p2begen + "']") — BenG
– BenG, Commented Dec 17, 2015 at 15:18
With this code you are modifying id i'416', remove those '. Also, as answered by others, the correct way to select ID is with # $('#element_id') — pablito.aven
– pablito.aven, Commented Dec 17, 2015 at 15:33

Paul Fitzgerald · Accepted Answer · 2015-12-17 15:24:27Z

3

To reference an id in jquery you need to add the #. See here in the jquery docs. It is important to note that ids must be unique, but you can use a class on as many elements as you like.

var p2begen = "416";
$("#i" + p2begen).attr("src", "check.png");

If you wish to use classes instead your code should look like this:

<img src="nocheck.png" class="i416" \>

var p2begen = "416";
$(".i" + p2begen).attr("src", "check.png");

edited Dec 17, 2015 at 15:24

answered Dec 17, 2015 at 15:18

Paul Fitzgerald

12.1k4 gold badges45 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

BenG Over a year ago

its an id not a class.

user198989 Over a year ago

Here is the deal, I want this applied on all the divs that has the same id. So will that do this ?

Paul Fitzgerald Over a year ago

You can only have one id... if you want to reference numerous elements by the same name you need to use a class name and then use . as opposed to #. there is a description here - ryanfait.com/articles/the-difference-between-ids-and-classes

Paul Fitzgerald Over a year ago

Does the solution work if you change it to use a class?

BenG · Accepted Answer · 2015-12-17 15:20:40Z

1

add the # at the start.

var p2begen = "416";
$("#i" + p2begen).attr("src", "check.png");

if you want to stick with the attribute selector, use:-

var p2begen = "416";
$("[id='#i" + p2begen + "']").attr("src", "check.png");

by adding the # and moving the ' back 2 places.

answered Dec 17, 2015 at 15:20

BenG

15.2k5 gold badges48 silver badges62 bronze badges

Comments

Brane · Accepted Answer · 2015-12-17 15:26:26Z

1

The simplest way for doing that is to use selector for ids, and your selector will looks like this:

var p2begen = "416";
$('#i' + p2begen).attr("src", "check.png");

answered Dec 17, 2015 at 15:26

Brane

3,3492 gold badges47 silver badges56 bronze badges

Collectives™ on Stack Overflow

Using a variable in jquery selector

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related