YIi PHP - Output array with a foreach loop

Question

I'm trying to return a navigation menu using Yii PHP framework, but my controller is only outputting the first item in the array, here's my code. Note that this pattern isn't using the traditional MVC, the model i'm asking data for is being displayed site-wide, not directly to its's controller->view.

Model - get data;

//output pages for getPagesMenuItems() in base controller
        public function getAllPages(){
            $criteria = new CDbCriteria();
            $criteria->condition = "visible = 1";
            return Pages::model()->findAll($criteria);
        }

Base controller in components

public $pagesMenuItems = array();
$this->pagesMenuItems = $this->getPagesMenuItems();

protected function getPagesMenuItems() {
        //Non admin users - links to pages
        if (Yii::app()->user->isGuest){

            $rows = Pages::getAllPages();

            foreach($rows as $row) {
            return    array(
                    //$row->id , $row->title , $row->guid , $row->visible
                    array('label' => $row->title, 'icon' => 'fa fa-times', 'url' => array('/admin/pages/view/id/' . $row->id)),
                    '---',
                );

            }
//            return array();
        }
        else {}
    }

And this is the view in the main.php

$this->widget('booster.widgets.TbMenu', array(  
                'items' => $this->pagesMenuItems,
                'id' => 'pagesNav'
            ));

I know the issue is packaging the array in the foreach loop, as i've tested the output of the model and all data is correct

Can anyone see where i'm going wrong in my controller?

Thanks

Chetan Ameta · Accepted Answer · 2015-12-08 09:49:26Z

3

change getPagesMenuItems function as below:

protected function getPagesMenuItems() {
    //Non admin users - links to pages
    $data = array();
    if (Yii::app()->user->isGuest){

        $rows = Pages::getAllPages();

        foreach($rows as $row) {
            $data[] = array('label' => $row->title, 'icon' => 'fa fa-times', 'url' => array('/admin/pages/view/id/' . $row->id));

        }
    }
    else {}
    return $data;
}

answered Dec 8, 2015 at 9:49

Chetan Ameta

7,8943 gold badges34 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

grhmstwrt Over a year ago

Thats fantastic mate, works a treat. i knew the issue was returning the array, just couldn't get syntax right. Thanks for your help

Collectives™ on Stack Overflow

YIi PHP - Output array with a foreach loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest