angularjs run named function

Question

What is wrong with this?

(function() {
    'use strict';

    angular
        .module('app')
        .run('pageTitle', pageTitle);

    function pageTitle($rootScope, $http) {
        $rootScope.$on('$routeChangeSuccess', function (event, current, previous) {
            $rootScope.title = current.$$route.title;
        });
    }

})();

I´m getting this error

Error: ng:areq

Bad Argument

Argument 'fn' is not a function, got string

Manno · Accepted Answer · 2015-10-11 23:09:24Z

1

As per Moncef Hassein-bey's answer, .run() only accepts one argument.

You also need to inject $rootScope and $http into your function or you will face further issues. Place the following line above your pageTitle function:

pageTitle.$inject = ['$rootScope', '$http'];

answered Oct 11, 2015 at 23:09

Manno

3991 gold badge3 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

handsome Over a year ago

thanks for the advice. should I do this for every function?

Manno Over a year ago

Only where the function requires dependency injection. If you are not passing any dependencies to the function then there is no need to $inject anything. Just to clarify, this only applies to named functions you use in your Controller, Service, Factory etc.

Moncef Hassein-bey · Accepted Answer · 2015-10-11 23:00:19Z

1

.run() accepts one argument, and it must be a function, so remove the first string.

angular.module('app').run(pageTitle);

answered Oct 11, 2015 at 23:00

Moncef Hassein-bey

1,3619 silver badges14 bronze badges

Collectives™ on Stack Overflow

angularjs run named function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related