Python code refactoring question. Applying functions to multiple elements

Question

I have code that looks something like this:

self.ui.foo.setEnabled(False)
self.ui.bar.setEnabled(False)
self.ui.item.setEnabled(False)
self.ui.item2.setEnabled(False)
self.ui.item3.setEnabled(False)

And I would like to turn it into something like this:

items = [foo,bar,item,item2,item3]
for elm in items:
    self.ui.elm.setEnabled(False)

But obviously just having the variables in the list with out the 'self.ui' part is invalid, and I would rather not type out 'self.ui' for every element in the list, because that really isn't to much better. How could I rewrite my first code to make it something like what I'm talking about?

Jonny Buchanan · Accepted Answer · 2010-06-30 15:52:53Z

4

Grab the object to have the function called on it by its attribute name using the built-in getattr function:

items = ['foo', 'bar', 'item', 'item2', 'item3']
for elm in items:
    getattr(self.ui, elm).setEnabled(False)

edited Jun 30, 2010 at 15:52

answered Jun 30, 2010 at 15:41

Jonny Buchanan

62.9k17 gold badges147 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

kafuchau · Accepted Answer · 2010-06-30 15:43:06Z

-3

You could try something like:

items = [foo,bar,item,item2,item3]
ui = self.ui
for elm in items:
    ui.elm.setEnabled(False)

answered Jun 30, 2010 at 15:43

kafuchau

5,6137 gold badges36 silver badges38 bronze badges

1 Comment

backus Over a year ago

When adding just the items foo,bar to the list items, you are referencing variables that do not exist. self.ui.foo != foo

Collectives™ on Stack Overflow

Python code refactoring question. Applying functions to multiple elements

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related