Java Array list adding only 1 item(the last key)while iterating over keys in a JSON object

Question

So I'm trying to get all the keys within a specific JSON Object but only the last key is obtained.

   public void setUpSearch(JSONObject data_json){

    Iterator<String> keys = data_json.keys();
    while (keys.hasNext()) {
        //get the key
        String key = keys.next();
        scripts = new ArrayList<String>();
        scripts.add(key);
        Log.i(TAG, key);
        Log.i(TAG, String.valueOf(scripts));
    }

Logtagging key shows all keys (around 300 of em), however logtagging scripts shows only the last one.

Any help will be highly appreciated.

Also, please do remember to accept your answers (all of them) if they have given you satisfactory answers (by clicking on the tick mark on the left of the answers), it would be helpful to the community – — TheCodingFrog
– TheCodingFrog, Commented Jun 27, 2015 at 17:22

TheCodingFrog · Accepted Answer · 2015-06-27 17:19:41Z

3

Because there is a BUG in your code. ArrayList initialization should be outside loop, otherwise you're overwriting previous one every time.

Use below code:

public void setUpSearch(JSONObject data_json){

    Iterator<String> keys = data_json.keys();
     scripts = new ArrayList<String>();

    while (keys.hasNext()) {
        //get the key
        String key = keys.next();
        scripts.add(key);
        Log.i(TAG, key);
        Log.i(TAG, String.valueOf(scripts));
    }

answered Jun 27, 2015 at 17:19

TheCodingFrog

3,5343 gold badges24 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3137329 Over a year ago

It worked like a charm. Ill accept your answer in 10 min

Collectives™ on Stack Overflow

Java Array list adding only 1 item(the last key)while iterating over keys in a JSON object

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related