Ruby, replacing values in a string array with strings/ints

Question

I'm trying to replace an array with a new array, replacing values as I go along.

Here's the code:

minesarray = [['*','.','.','.'],['.','.','*','.'],['.','.','.','.']]

def pp_board(board)
    puts Array.new(board[0].size*2+1, '-').join('')
    board.each do |row|
        puts "|" + row.join("|") + "|"
        puts Array.new(row.size*2+1, '-').join('')
    end
end

pp_board(minesarray)

count = 0

minesarray.map{ |row|
    row.each { |col|
        if minesarray[row][col] = '*'
            minesarray[row][col]="a"
        elif minesarray[row][col] = '.'
            minesarray[row][col] = 0
        end
    }
}

I receive the following error:

mines2.rb:17:in '[]': can't convert Array into Integer (TypeError)
   from mines2.rb:17:in 'block (2 levels) in (main)'
   from mines2.rb:16:in 'each'
   from mines2.rb:16:in 'block in (main)'
   from mines2.rb:15:in 'map'
   from mines2.rb:15:in '(main)'

Start with elif => elsif, and fix if minesarray[row][col] = '*' — Yu Hao
– Yu Hao, Commented Apr 8, 2015 at 3:42

xdazz · Accepted Answer · 2015-04-08 03:44:23Z

2

The row and col is not the index of the array, but the element itself.

You could do like below:

minesarray = [['*','.','.','.'],['.','.','*','.'],['.','.','.','.']]

def pp_board(board)
    puts Array.new(board[0].size*2+1, '-').join('')
    board.each do |row|
        puts "|" + row.join("|") + "|"
        puts Array.new(row.size*2+1, '-').join('')
    end
end

pp_board(minesarray)

minesarray = minesarray.map { |row|
  row.map { |v|
    if v == '*'
      'a'
    elsif v == '.'
      '0'
    end
  }
}

pp_board(minesarray)

answered Apr 8, 2015 at 3:44

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tom Dalling · Accepted Answer · 2015-04-08 03:44:47Z

1

The problem is that row and col are not indexes, they are the actual elements of the array.

You also have a couple of other issues. "elif" should be elsif and you're using assignment (=) in your conditionals where you should be using an equality check (==).

answered Apr 8, 2015 at 3:44

Tom Dalling

24.2k7 gold badges64 silver badges81 bronze badges

Collectives™ on Stack Overflow

Ruby, replacing values in a string array with strings/ints

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related